Re: [eclipse-pmc] Should we accept any patchestoattractmorecontributors?
> I could image for example a "Forward/Backwards" button in the Git blame
> popup which makes is easier to see the access the history of a
> particular line.
I think the "Show Revision Information" link on the pop-up does something similar by opening the previous version in an editor. It also jumps to the correct line and the revision information is shown on this version to quickly navigate to the version previous to that.
(See attached file: Revision.gif)
Lars Vogel ---11/16/2018 03:11:44 PM---> so please don't change the topic. I agree with Alex that we should not use this thread to discuss
From: Lars Vogel <lars.vogel@xxxxxxxxxxx>
Date: 11/16/2018 03:11 PM
Subject: Re: [eclipse-pmc] Should we accept any patches toattractmorecontributors?
Sent by: eclipse-pmc-bounces@xxxxxxxxxxx
> so please don't change the topic.
I agree with Alex that we should not use this thread to discuss
unrelated things. I think Toms answer summarizes it nicely:
I agree with Lars, Alex and Dani. Code clean-up should generally be
accepted over maintaining git blame usefulness.
I will bring this to our next PMC meeting that we put this guidance
for the Eclipse top-level projects into a central place, e.g., a wiki
or maybe even the project charter. IMHO this would be helpful to
handle consistently our contribution process.
I also like Sarikas proposal to enhance EGit blame functionality, I
could image for example a "Forward/Backwards" button in the Git blame
popup which makes is easier to see the access the history of a
particular line. Lets discuss the details or other suggestion in the
bug from Sarika.
Best regards, Lars
On Fri, Nov 16, 2018 at 8:48 AM Aleksandar Kurtakov <akurtako@xxxxxxxxxx> wrote:
> On Fri, Nov 16, 2018 at 9:30 AM Aleksandar Kurtakov <akurtako@xxxxxxxxxx> wrote:
>> On Fri, Nov 16, 2018 at 8:56 AM Szymon Ptaszkiewicz <sptaszkiewicz@xxxxxxxxx> wrote:
>>> Hi all,
>>> I just want to point out that students and newcomers that may or may not become regular contributors or even committers is just one point of view. The other one is that apart from git history that gets broken immediately there is another consequence which comes later - accepting low quality
>> ^^^ as I said in the gerrit - it's fine to reject a patch if there is issue with it but "it will pollute git history" is not an issue with the patch or actually it's an issue with every patch so we should stop doing any change - so please don't change the topic.
>>> or questionable patches causes existing highly skilled committers to leave.
> And if one looks at the history of recent breakages we had they are all(at least I can't think of a single breakage created by external contribution non-technical changes in the last few months) caused by us (so called skilled committers) and this is normal! due to the type of issues taken by these people.
> Furthermore these breakages are caused (in my opinion) by people trying to delay any changes till the very last moment which eventually leads to any mandatory change that has to be done to be accompanied by tens of others thus destabilizing everything. The sole fact the we see the IDE getting less buggy and speedier with more contributors joining proves that this is the right path and not some elithist, delay till dead of stagnation and other similar strategies.
>>> Example is here: https://www.eclipse.org/lists/eclipse-dev/msg10445.html
>>> Best regards,
>>> eclipse-pmc mailing list
>>> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
>> Alexander Kurtakov
>> Red Hat Eclipse Team
> Alexander Kurtakov
> Red Hat Eclipse Team
> eclipse-pmc mailing list
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
Eclipse Platform project co-lead
CEO vogella GmbH
Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
Fax (040) 5247 6322, Email: lars.vogel@xxxxxxxxxxx, Web: http://www.vogella.com
eclipse-pmc mailing list
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
Description: GIF image