Re: [eclipse-pmc] Should we accept any patchestoattractmorecontributors?

["Daniel Megert" <daniel_megert@xxxxxxxxxx>]

> I
can create a bug to discuss this.

Sure. A first
improvement could be to directly allow to ignore a revision in the revision
ruler.

Dani



From:
       "Sarika
Sinha" <sarika.sinha@xxxxxxxxxx>
To:
       eclipse-pmc@xxxxxxxxxxx
Date:
       16.11.2018
07:13
Subject:
       Re:
[eclipse-pmc] Should we accept any patches        toattractmorecontributors?
Sent
by:        eclipse-pmc-bounces@xxxxxxxxxxx

---

As it appears, the bottle neck is git blame and git history. I think we can improve these functionalities to consider users's preference to ignore the clean up commits if they are tagged accordingly.
I can create a bug to discuss this.

Thanks & Regards,
Sarika

"Thomas Watson"
---11/15/2018 08:59:28 PM---I agree with Lars, Alex and Dani. Code clean-up
should generally be accepted over maintaining git b

From: "Thomas Watson" <tjwatson@xxxxxxxxxx>
To: eclipse-pmc@xxxxxxxxxxx
Date: 11/15/2018 08:59 PM
Subject: Re: [eclipse-pmc] Should
we accept any patches to attractmorecontributors?
Sent by: eclipse-pmc-bounces@xxxxxxxxxxx

---

I agree with Lars, Alex and Dani. Code clean-up should generally be accepted
over maintaining git blame usefulness.

Tom



----- Original message -----
From: "Daniel Megert" <daniel_megert@xxxxxxxxxx>
Sent by: eclipse-pmc-bounces@xxxxxxxxxxx
To: eclipse-pmc@xxxxxxxxxxx
Cc:
Subject: Re: [eclipse-pmc] Should we accept any patches to attract morecontributors?
Date: Thu, Nov 15, 2018 7:59 AM

I generally agree with Lars and Alex as long as the clean-up is really
improving the code (performance, readability, etc.). I would turn down
clean-ups that just change the code based on personal taste.

In the actual case I agree with the change for two reasons:

1. It is easier to read (yes, personal opinion/taste).
2. In many cases #isEmpty() is faster.

Dani



From: "Andrey
Loskutov" <loskutov@xxxxxx>
To: pmc <eclipse-pmc@xxxxxxxxxxx>
Date: 15.11.2018
10:35
Subject: [eclipse-pmc]
Should we accept any patches to attract more contributors?
Sent by: eclipse-pmc-bounces@xxxxxxxxxxx

---

Hi all,

Please see discussion on https://git.eclipse.org/r/#/c/132436/and
also on https://git.eclipse.org/r/#/c/131015/.
I've rejected patch https://git.eclipse.org/r/#/c/132436/with
-2 and voted -1 on https://git.eclipse.org/r/#/c/131015/.

At the end I was asked to bring the issue "how/what the project should
value more" to PMC.
I guess Alex wanted to ask is we should not "down vote" patches
to have more contributors.

My point on the gerrit was that mass change patches without functional
changes (or with questionable changes) are not acceptable because they
make code maintenance harder due broken git blame.
I've made this -2 and -1 not because it is a matter of taste from me, which
code style is better or not, but because code maintenance is also about
understanding the history of the code, which is interrupted forever by
such mass changes.

I observe the results of such patches in Platform UI project, which had
numerous *non-functional* "code cleanups" behind it and now it
is impossible to use git blame on affected code.
So all what I want is just to keep git history clean from non functional
mass changes. I do not see how accepting non functional mass changes can
attract more people.

Kind regards,
Andrey Loskutov

Спасение утопающих - дело рук самих утопающих

http://google.com/+AndreyLoskutov
_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://www.eclipse.org/mailman/listinfo/eclipse-pmc



_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://www.eclipse.org/mailman/listinfo/eclipse-pmc

_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://www.eclipse.org/mailman/listinfo/eclipse-pmc

[attachment "graycol.gif" deleted by Daniel Megert/Zurich/IBM]
_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://www.eclipse.org/mailman/listinfo/eclipse-pmc