Re: [rest-dev] Proposed change to Committer-Conventions

[James Perkins <jperkins@xxxxxxxxxx>]

+1

Note I feel this is important now as we want to get something into Jakarta EE 11. We have until the 2024-03-29 to have a release. If we continue to have to wait 2 weeks we have to have all PR's in by I would say at least March 15th. That itself is nearly 2 weeks away.

On Tue, Feb 27, 2024 at 6:36 AM Jim Krueger via rest-dev <rest-dev@xxxxxxxxxxx> wrote:

In an effort to allow for accelerated development, while still maintaining control over Jakarta Restful Webservices content, I’d like to start discussion over the following change to our Committer-Convenstions (https://github.com/jakartaee/rest/wiki/Committer-Conventions)

Currently the "Minimum Length of review period before merge / close of PRs and closing of Issues" section states the following:

(1) Minimum two full weeks is default.

(2) For non-API, non-spec, non-javadoc changes (e.g., pom, travis, checkstyle, etc), a proposal to fast track the PR is requested at submission time. If a fast tracked PR receives 3 committer +1 votes (and no -1), it can be merged immediately provided at least 1 day has passed since its submission.

Rule #1 above makes it impossible to fix API, spec, or javadoc changes in a situation that demands a faster response.   I’d therefore like to add the following to this list:

(3) For any time-sensitive change, a proposal to fast track the PR is requested at submission time.  If a fast tracked PR receives 4 committer +1 votes (and no -1 vote), it can be merged immediately provided at least 1 day has passed since its submission.  If a fast tracked PR receives only 2 or 3 +1 votes (and no -1 vote), it can be merged provided at least 4 days have passed since its submission.  

Thoughts?

_______________________________________________
rest-dev mailing list
rest-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://accounts.eclipse.org

--

James R. Perkins

JBoss by Red Hat