Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [rest-dev] [External] : Proposed change to Committer-Conventions
  • From: Santiago Pericasgeertsen <santiago.pericasgeertsen@xxxxxxxxxx>
  • Date: Tue, 27 Feb 2024 15:40:45 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RPNwHwcJXqMlsakaizCI8uvy7IW+0R7V3mfdU3LO51s=; b=LKLonBL9y5aqEGFFQHxPez7xshVVXCTvYc5Jufvyp11i6/voRA92FCWDOZCAoBdkwWT+t93NvhTofiQceORdHd3KcLVvJdrnt5KPH+HXYQm4zgDokTc3wVGgI/UnukkC+lZSSCFqjcGGuUTKNJr7aDm9QOJZnxDcWkCo4bSo49Nogkjyi+z8NMZIKnU1wDIS0OfSuCnaXEcZFbWb8RKdJv/V05w+veI5NOG6zvt8+PYSZHnSC8g33aZxHuuaGM0iGUrdjH7CR0QViwgB4VS3xjJZFxpXzZ3zqZAFRHtjBDGeInCy040yH/Vu7KpHbh+vLy7C7hlwD/7NEdC+00bB+w==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gjt+ztvZb2l78/eIOJ5w6g0ZYjYT3CHBC2kbpNptubNdeKHEHa96uv++1eOnlFDtBIm8uH5E0bPYq9y2gHY0swz487XCxC4s2cSxWS8yzhIS0X4sFnielb/n3bymU3AfwlEeAeVFaVnLJmgSeXnqaQzjiA2Vo5W6oJPIg2iArerZiDI0eIBskANKVbIcPMVLNGPHHaMDVoSAc2ppp5/R4WwpSO5n3hqLNkc4w7i6QMpm3TsnOS3bFFnoqxS+lg7P2VfEI/hcfdXq29VIUqKrh8k4rF81BLIyJtEppzhRImGYeYjMUFKnk0K0MQqFELyXo8vRSHWEnnKPAXMjYabFGw==
  • Delivered-to: rest-dev@xxxxxxxxxxx
  • List-archive: <https://www.eclipse.org/mailman/private/rest-dev/>
  • List-help: <mailto:rest-dev-request@eclipse.org?subject=help>
  • List-subscribe: <https://www.eclipse.org/mailman/listinfo/rest-dev>, <mailto:rest-dev-request@eclipse.org?subject=subscribe>
  • List-unsubscribe: <https://www.eclipse.org/mailman/options/rest-dev>, <mailto:rest-dev-request@eclipse.org?subject=unsubscribe>
  • Thread-index: AQHaaYpl/GHeKHMlkESzkWV5ZEA5/LEeU4UA
  • Thread-topic: [External] : [rest-dev] Proposed change to Committer-Conventions

 +1

— Santiago

On Feb 27, 2024, at 9:36 AM, Jim Krueger via rest-dev <rest-dev@xxxxxxxxxxx> wrote:

In an effort to allow for accelerated development, while still maintaining control over Jakarta Restful Webservices content, I’d like to start discussion over the following change to our Committer-Convenstions (https://github.com/jakartaee/rest/wiki/Committer-Conventions)

Currently the "Minimum Length of review period before merge / close of PRs and closing of Issues" section states the following:

(1) Minimum two full weeks is default.

(2) For non-API, non-spec, non-javadoc changes (e.g., pom, travis, checkstyle, etc), a proposal to fast track the PR is requested at submission time. If a fast tracked PR receives 3 committer +1 votes (and no -1), it can be merged immediately provided at least 1 day has passed since its submission.

Rule #1 above makes it impossible to fix API, spec, or javadoc changes in a situation that demands a faster response.   I’d therefore like to add the following to this list:

(3) For any time-sensitive change, a proposal to fast track the PR is requested at submission time.  If a fast tracked PR receives 4 committer +1 votes (and no -1 vote), it can be merged immediately provided at least 1 day has passed since its submission.  If a fast tracked PR receives only 2 or 3 +1 votes (and no -1 vote), it can be merged provided at least 4 days have passed since its submission.  

Thoughts?

_______________________________________________
rest-dev mailing list
rest-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://urldefense.com/v3/__https://accounts.eclipse.org__;!!ACWV5N9M2RV99hQ!ILuUuiIrrrnXX8IrVUVcO5Th5rX8UUQDs6AZdfckVuK-YfI7KLOO8jUYDQvJKePt0eeLyifqVQqXAbC_ZEtDeivZ0IA1$

Back to the top