Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [rest-dev] [External] : Proposed change to Committer-Conventions
  • From: Jan Supol <jan.supol@xxxxxxxxxx>
  • Date: Tue, 27 Feb 2024 22:57:49 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sY96iGODvH0J6HwDnwB+MW9q4aY7QKKthbuqbOyRuw0=; b=OUhxkD7rA6kHP8TgNS+5Y1zFhDV0e4nV5IxAir1At8dMZ5v6PadtY+dkPcf2eIlDaxeVe7DbaKmFh4CEAGFTTupoM2D/YCN44NShWcZW/QZVeJoSAhL4VWE8U0Ue63qjPxdlBIk6eR2nKTaWNqujtT/Y4xOd7hXqmeBHsB4Pp70nzSL+cG7DaayWXTr+yJG5QjyQ3R3klDw/qW0DTouOPceAnDH6N3Bl1Z4oRva/SanArrzPypFgdqd/Bp0m4lavdpTpUZv6Cdc3uHpQKez1aQkPTdJzrOngbmAN5UZJc/WBvrB5l3j5DBwkfqsrHGOxnING5aOEOzyb68xvPYILxg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O9BE4Jk1Rq6VARgcsJ/mxGteq5eBGLfu27PyjjuvfFHMyMVwabNnoGeuzZlhCHH3ViCFbHpe7KE5t7r7/ciXbOCePYt3PLDcBdS43gK+9DXfCRNALOBzGnpRI2Oa4TP2mH0fiuO7TTtnt9hrjX3oqb1p1sDFMOamAC0YnKas8pCq7dTeOohS6C/Qcb3mmPQyvykcHiTRp6zI5Q+r8lOm9DXN/VCueEb6Zi6XMYxVTj7FWcNRRcRLWSd0+WO7Fk4b0jwWivtAQS+KSLkRHSwRkpj7RkaCQESyDC78tcmx+NuqEQf67I78VRcVAMEPxdpcpjbP9Eutdy/qPbr3ZgEQqA==
  • Delivered-to: rest-dev@xxxxxxxxxxx
  • List-archive: <https://www.eclipse.org/mailman/private/rest-dev/>
  • List-help: <mailto:rest-dev-request@eclipse.org?subject=help>
  • List-subscribe: <https://www.eclipse.org/mailman/listinfo/rest-dev>, <mailto:rest-dev-request@eclipse.org?subject=subscribe>
  • List-unsubscribe: <https://www.eclipse.org/mailman/options/rest-dev>, <mailto:rest-dev-request@eclipse.org?subject=unsubscribe>
  • Msip_labels:
  • Thread-index: AQHaaYpliQqxzAXG20SMQmAIsa6oqLEezHgG
  • Thread-topic: [External] : [rest-dev] Proposed change to Committer-Conventions
+1 temporarily for EE11.

For others, there are the development/release branches (Which could have been used for EE11 as well, and the only reason why they are not used I can see is the last 2 week approval period from the release branch to main, correct?)


From: rest-dev <rest-dev-bounces@xxxxxxxxxxx> on behalf of Jim Krueger via rest-dev <rest-dev@xxxxxxxxxxx>
Sent: Tuesday, February 27, 2024 3:36 PM
To: Jakarta Rest project developer discussions <rest-dev@xxxxxxxxxxx>
Cc: Jim Krueger <jckofbyron@xxxxxxxxx>
Subject: [External] : [rest-dev] Proposed change to Committer-Conventions
 
In an effort to allow for accelerated development, while still maintaining control over Jakarta Restful Webservices content, I’d like to start discussion over the following change to our Committer-Convenstions (https://github.com/jakartaee/rest/wiki/Committer-Conventions)

Currently the "Minimum Length of review period before merge / close of PRs and closing of Issues" section states the following:

(1) Minimum two full weeks is default.

(2) For non-API, non-spec, non-javadoc changes (e.g., pom, travis, checkstyle, etc), a proposal to fast track the PR is requested at submission time. If a fast tracked PR receives 3 committer +1 votes (and no -1), it can be merged immediately provided at least 1 day has passed since its submission.

Rule #1 above makes it impossible to fix API, spec, or javadoc changes in a situation that demands a faster response.   I’d therefore like to add the following to this list:

(3) For any time-sensitive change, a proposal to fast track the PR is requested at submission time.  If a fast tracked PR receives 4 committer +1 votes (and no -1 vote), it can be merged immediately provided at least 1 day has passed since its submission.  If a fast tracked PR receives only 2 or 3 +1 votes (and no -1 vote), it can be merged provided at least 4 days have passed since its submission.  

Thoughts?

Back to the top