Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [platform-dev] Github workflow
  • From: Sravan K Lakkimsetti <sravankumarl@xxxxxxxxxx>
  • Date: Thu, 24 Mar 2022 13:01:04 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=in.ibm.com; dmarc=pass action=none header.from=in.ibm.com; dkim=pass header.d=in.ibm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YfUUig0uSVRADY7TvNK9O3AmesOpCyx3YgYPCJ/dSrU=; b=MtybFdLSDbc5+5jNJbFgXQefOmguHpLMLGdLTXhSK2vccvAMWfqazJPEY5uK/6SzNwVF3aMQzb+4nhwRxIsMqmQrhihBJcLpr/oGwO0lWozLf9Yj1VarqvVvuTu9xX+N3YFou3LNwFkUztNqkF+/xCNvX5rMSlZpxeMDQXOCQHhKr7+MTzrV7C95MIkg+9VxEf2/mKZ79YzKVqyP6CNB58vpQQVOYA+7Yx/0K9zNwG+klbU6reSjFGOSoc26uSqVRKKF79GjqIwmmUtWzgrgm94uSwV+D42C0NAQcK5wjmHtEIyJ/ms7vi8gvXaRlzbSVOp+ysgZx93AJOsMByBXSQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LZc6saWXpu93w0PVXC1OhKM5qpVRjlC6l7RkFGdEKVM6sakhTMDyXWusaZm4Htphmc8g+N30H3HzfNZFX8CUBuEW9tM9XT7rVcyk7eSRTvToHwpgfUUZTiwsJIK+v6vY8C3/I/M0rot0UlgyJE//UlVjkoZ9VEtQFCzqd/dMGvYywo9cqpAJXG+ibY2Wjq2VxCDrTdOMzWWQN9tq/71GY1g/EfoXDdqUH12bwwVziX+SDc+HbV8AZdD+ymlAiFG53iTpSV94lmknmdxlN1aRr4A97itbgTjFPEurZy0hSFUhQORO3HvtsPcA1ESPksZm5FCnUErHCP5Ra59PJ1yBdg==
  • Delivered-to: platform-dev@xxxxxxxxxxx
  • List-archive: <https://www.eclipse.org/mailman/private/platform-dev/>
  • List-help: <mailto:platform-dev-request@eclipse.org?subject=help>
  • List-subscribe: <https://www.eclipse.org/mailman/listinfo/platform-dev>, <mailto:platform-dev-request@eclipse.org?subject=subscribe>
  • List-unsubscribe: <https://www.eclipse.org/mailman/options/platform-dev>, <mailto:platform-dev-request@eclipse.org?subject=unsubscribe>
  • Thread-index: AQHYPdRZkv2FPR8E7E6yMLWIhkzglqzLTTyAgAAT6GCAAi1xAIAA5e0AgAAIdfA=
  • Thread-topic: [EXTERNAL] Re: [platform-dev] Github workflow

>> It is unclear / undocumented how to *properly* refer to bugs in commits (full url? repo-name/id? just id?).
>> It is unclear if we should now use dedicated github bug trackers *per repository* to report bugs, or will be there some higher level bug tracker for entire platform organization?

 

Here are my suggestions on this.

  1. All the commits should have an issue, created in the same repository, number associated with them
    1. <description of change> #<issue number>
  2. For root level issues like work spanning across multiple repositories, I would prefer root bugs to be created in
    1. Platform in https://github.com/eclipse-platform/eclipse.platform
    2. Equinox in https://github.com/eclipse-equinox/equinox.framework
    3. Pde in eclipse.pde.ui
    4. Jdt in https://github.com/eclipse-jdt/eclipse.jdt
  3. If issues span across multiple projects(organizations), my preference would be https://github.com/eclipse-platform/eclipse.platform

 

Thanks

Sravan

From: platform-dev <platform-dev-bounces@xxxxxxxxxxx> On Behalf Of Mickael Istria
Sent: 24 March 2022 17:40
To: Eclipse platform general developers list. <platform-dev@xxxxxxxxxxx>
Subject: [EXTERNAL] Re: [platform-dev] Github workflow

 

Hi, I'm putting a few answers here, but those could go to the document pointed out by Sravan (which by the way could be renamed to CONTRIBUTING.md)   I don't like forks and used to have branches on main repo - not recommended. ‍ ‍ ‍ ‍ ‍ ZjQcmQRYFpfptBannerStart

This Message Is From an External Sender

This message came from outside your organization.

ZjQcmQRYFpfptBannerEnd

Hi,

 

I'm putting a few answers here, but those could go to the document pointed out by Sravan (which by the way could be renamed to CONTRIBUTING.md)

 

I don't like forks and used to have branches on main repo - not recommended.

 

Indeed. The "upstream" repo shouldn't be used as a workspace for ongoing work. Your workspace is your fork.

 

I don't like multiple commits in one PR and always use amend/force push - not recommended.

 

That's *not* not recommended. It's just something that is up to the submitter, we shouldn't recommend anything here and let contributors build the workflow they prefer.

What needs to be recommended is how we merge and keep a meaningful granularity for commits, not how contributors submit their PRs.

 

I never use command line git and do everything from Eclipse - but some recommended to use git CLI.

 

What typical commands do you have in mind? GitHub really is standard Git when it comes to push/fetch, the only thing to know is that reference to fetch/merge a PR is `pulls/123/head`, so there is no Git fanciness needed and EGit can be used for most operations. The only operation needed is the creation of a pull request and its review, that usually happens via an external tool (eg GitHub website).

 

Egit support missing or not - not clear. What exactly is missing, why CLI is needed?

 

There is decent support for GitHub in EGit. If anything is missing, it should be reported to EGit.

 

It is unclear / undocumented how to *properly* refer to bugs in commits (full url? repo-name/id? just id?).
It is unclear if we should now use dedicated github bug trackers *per repository* to report bugs, or will be there some higher level bug tracker for entire platform organization?

 

I believe that is still to be determined, as we're growing collective experience here.

 

Once the PR is created, I see that builds somehow triggered in equinox, but I neither get mails that they are stared nor they are finished.

 

That's an interesting thought. I don't know whether there is some option to allow email notifications for votes.

 

Back to the top