Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [epp-dev] Incubation packages

After reading all this I realize that the label shown in the installer for each package is derived from the IU name of the product.   Those names are currently as follows:

https://download.eclipse.org/oomph/archive/reports/download.eclipse.org/releases/2020-03/http___download.eclipse.org_technology_epp_packages_2020-03_RC1.html

These names have diverged significantly from the names in the corresponding epp.website.xml.   E.g., Rust has the name Eclipse IDE for Rust Developers (includes Incubating components):

  https://git.eclipse.org/c/epp/org.eclipse.epp.packages.git/tree/packages/org.eclipse.epp.package.rust.feature/epp.website.xml#n11

I see that the RCP one has changed to remove "(includes incubating components)"; note that for RCP it's "incubating" rather than "Incubating" like used in Rust:

  https://git.eclipse.org/c/epp/org.eclipse.epp.packages.git/commit/packages/org.eclipse.epp.package.rcp.feature/epp.website.xml?id=88af72e37d3c97927858db0b6feba3a2d71da1a2

As Johan already noted, the text still mentions a statement of the "no-longer-a-fact" that Passage is incubating:

  https://git.eclipse.org/c/epp/org.eclipse.epp.packages.git/tree/packages/org.eclipse.epp.package.rcp.feature/epp.website.xml#n18

It seems to me that "Eclipse Modeling Tools" stands out like sore thumb.  Perhaps "Eclipse IDE for Modeling" or "Eclipse IDE for Model Developers" would fit better with the overall style for all the other "Eclipse IDE for" variants.

It's kind of a horrible mess and this labeling looks horribly verbose in the installer.

Also, technically, if you read the copious and onerous rules related to incubation, you'll eventually find this:

  https://www.eclipse.org/projects/handbook/#starting-incubation-branding

And here you'll see that the OSGi artifacts should include the word "incubation":

  https://www.eclipse.org/projects/handbook/#starting-incubation-branding

But let's pretend we didn't read that and hope that the enforcers don't call us out...

To work around this mess, I've changed the product catalog generator to extract that project label from each corresponding epp.website.xml given that this seems somewhat more consistently maintained by the EPP committers.

https://bugs.eclipse.org/bugs/show_bug.cgi?id=560901

But this still left me with the issue that generating information for all the historical older versions where I figured I can really only determine "incubation" from the product IU name.  There used to be branches for each release such that I could (at least in principle) look at the historical state of  each epp.website.xml .  Fortunately I realized that another workaround is to use the "branding site link" which is driven by the packageName in the epp.website.xml, e.g., for RCP there exist this link:

  https://www.eclipse.org/downloads/packages/release/2020-03/rc1/eclipse-ide-rcp-and-rap-developers-includes-incubating-components

For the historical 2019-12 release there is this link:

  https://www.eclipse.org/downloads/packages/release/2019-12/r/eclipse-ide-rcp-and-rap-developers-includes-incubating-components

As such, from this historical scanning of all the older website links, I can determine that the above older version of RCP was incubating for that release.

In anticipation of all the last-minute proliferation of "(includes incubating components)"---please decide as a group whether the "I" in "incubating" should be uppercase or not---I've also changed the product catalog generator to remove this parenthetical text from the product label. 

So Rust will look like this:

Thanks Max Bureck for finally providing a usable branding icon for the installer!

_javascript_ will instead look like this:

When the product is selected, whether its incubating or not (which depends in general on which version is being installed) will be evident like this:

This still conforms to the incubation branding guidelines, while not screaming quite so verbosely and so loudly, "this may contain questionable stuff".  Note the new "details" link which links to the branding site, i.e., currently:

https://www.eclipse.org/downloads/packages/release/2020-03/rc1/eclipse-ide-rust-developers-includes-incubating-components

On 06.03.2020 16:31, Jonah Graham wrote:
Thank you Markus for the clarification.

The conclusion is that many more packages should be called incubation packages. In total that should be (in brackets is an incubating component I identified):

- CPP (swtchart)
- Rust (lsp4e/j)
- JEE (?)
- Committers (?)
- _javascript_  (lsp4e/j)
- DSL (lsp4j)

i.e. 6 of the 13 packages.

Also, the description of RCP still says "The Eclipse Passage (Incubation)" https://git.eclipse.org/c/epp/org.eclipse.epp.packages.git/tree/packages/org.eclipse.epp.package.rcp.feature/epp.website.xml so that needs a fix too.

Can package owners fix their own packages if needed please before Thursday?


Thanks
Jonah

~~~
Jonah Graham
Kichwa Coders
www.kichwacoders.com


On Fri, 6 Mar 2020 at 09:00, Markus Knauer <mknauer@xxxxxxxxxxxxxxxxx> wrote:
The rule is... as soon as a package contains content from a project in incubation phase, it needs to be marked as such, i.e. it needs the string "incubation" in its file name and labeled on the download page with "includes incubating components". For milestone releases it may be acceptable if a label is wrong, for a release it must be accurate.

Most people prefer not to have such a label for a package, some package maintainers don't include components from incubating projects at all.

I cannot speak of other packages, but

- The Rust package started as package with incubating components. Maybe the status has changed in the meantime. If this is the case, it should be updated.
- The RCP/RAP package used to contain some incubating components for a short period of time, but was never released with it. I've updated its name now in the following commit https://git.eclipse.org/c/epp/org.eclipse.epp.packages.git/commit/?id=88af72e37d3c97927858db0b6feba3a2d71da1a2

Regards,
Markus

On Fri, 6 Mar 2020 at 14:16, Jonah Graham <jonah@xxxxxxxxxxxxxxxx> wrote:
I think the CPP one too because it has swtchart in it now.
~~~
Jonah Graham
Kichwa Coders
www.kichwacoders.com


On Fri, 6 Mar 2020 at 08:11, Mickael Istria <mistria@xxxxxxxxxx> wrote:
The "Eclipse IDE for _javascript_ and Web developers" started integrating Wild Web Developer recently, so it should have be changed to add "-incubation" in its name if it's the rule.
Same applies to "Eclipse IDE for Enterprise Java developers" I believe.
_______________________________________________
epp-dev mailing list
epp-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/epp-dev
_______________________________________________
epp-dev mailing list
epp-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/epp-dev


_______________________________________________
epp-dev mailing list
epp-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/epp-dev

_______________________________________________
epp-dev mailing list
epp-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/epp-dev

Back to the top