Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[jta-dev] Requesting a project committer to review a (large) PR

Hi,

Please can I request for a review from one of the Jakarta Transactions project committers [1] for [2].

I am not really sure how we want to deal with this though!

Hopefully we have been fairly diligent and pull requests for the changes have been reviewed by either myself or another project committer for the spec-doc-conversion branch prior to now so I am not sure if we would need the reviewer to go through each commit or even the file changes themselves again or whether maybe it is enough to verify that the pull request is producing build output that could reasonably be considered a draft Jakarta Transactions 2.0 specification (it does look like it to me).

Also, once this is merged I think we should delete the branch: https://github.com/eclipse-ee4j/jta-api/tree/spec-document-conversion

Thanks!
Tom

[1] https://projects.eclipse.org/projects/ee4j.jta/who
[2] https://github.com/eclipse-ee4j/jta-api/pull/161

Back to the top