Re: [jakartaee-tck-dev] How do we exclude signature TCK tests?

[Scott Marlow <smarlow@xxxxxxxxxx>]

On 1/27/21 12:18 PM, Brian M Decker wrote:

Scott,

To address the direct question (naively ignoring Lance's general objection), it also seems to work to add the two specific classes into [1] to skip only them without ignoring entire packages.

In this case, that would mean adding:
jakarta.faces.validator.FacesValidator
jakarta.faces.component.behavior.FacesBehavior

Thanks Brian!  Good to hear that the package list helped!  With respect to the feedback from Lance, it sounds like excluding any signature tests would impact compatibility in a bigger way than we might see when just excluding particular tests.

From my work on https://github.com/eclipse-ee4j/jakartaee-tck/issues/156 (mentioned in the other TCK mail thread just opened last night), I found that the JDK SigTest tooling only ignores the package/exclude list for some SigTest internal use but not all, so good to hear it helped for your testing.

-Brian

[1] https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/install/jakartaee/bin/sig-test-pkg-list_se8.txt



Scott Marlow ---01/27/2021 08:35:49 AM---On 1/26/21 11:14 PM, Alwin Joseph wrote: >

From: Scott Marlow <smarlow@xxxxxxxxxx>
To: jakartaee-tck developer discussions <jakartaee-tck-dev@xxxxxxxxxxx>, Alwin Joseph <alwin.joseph@xxxxxxxxxx>
Date: 01/27/2021 08:35 AM
Subject: Re: [jakartaee-tck-dev] [External] : How do we exclude signature TCK tests?
Sent by: "jakartaee-tck-dev" <jakartaee-tck-dev-bounces@xxxxxxxxxxx>

---

On 1/26/21 11:14 PM, Alwin Joseph wrote: @font-face {font-family:"Cambria...

This Message Is From an External Sender

This message came from outside your organization.

On 1/26/21 11:14 PM, Alwin Joseph wrote:

Hi Scott,
 
I believe the failing packages can be removed from [1] to skip the same instead of excluding the entire signature test.
 
[1] https://github.com/eclipse-ee4j/jakartaee-tck/blob/c4ba90c54678dee5af42a886784df84f8838032f/src/com/sun/ts/tests/signaturetest/javaee/JavaEESigTest.java#L194

Ah interesting, thanks Alwin!

 
 
From: jakartaee-tck-dev <jakartaee-tck-dev-bounces@xxxxxxxxxxx> on behalf of Scott Marlow <smarlow@xxxxxxxxxx>
Reply to: jakartaee-tck developer discussions <jakartaee-tck-dev@xxxxxxxxxxx>
Date: Wednesday, 27 January 2021 at 8:40 AM
To: jakartaee-tck developer discussions <jakartaee-tck-dev@xxxxxxxxxxx>
Subject: [External] : [jakartaee-tck-dev] How do we exclude signature TCK tests?
 

Hi,

I'm looking at faces-api/issues/1474 [1] and am wondering if we can exclude the following TCK tests:

- com/sun/ts/tests/signaturetest/javaee/JavaEESigTest.java#signatureTest_from_jsp
- com/sun/ts/tests/signaturetest/javaee/JavaEESigTest.java#signatureTest_from_servlet

More specifically, we only want to exclude the Jakarta Faces annotations signatures mentioned in [2].
Scott

[1] https://github.com/eclipse-ee4j/faces-api/issues/1474
[2] https://github.com/eclipse-ee4j/faces-api/issues/1474#issuecomment-528880074


_______________________________________________
jakartaee-tck-dev mailing list
jakartaee-tck-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev
_______________________________________________
jakartaee-tck-dev mailing list
jakartaee-tck-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev

_______________________________________________
jakartaee-tck-dev mailing list
jakartaee-tck-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev