[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [glassfish-dev] Question about nightly builds and running TCKs
|
Hi Matej,
Sorry about the name I must have looked at Martin's in CC.
Currently my branch doesn't compile as it hit a blocker in that some of the integration SPIs we reference in Weld obviously still use the javax namespace. My branch started out as incorporating Jakarta connectors but has grown due to dependencies to suck in Jakarta Transactions, EJB and now CDI. It is good fun!
I saw that Scott has a version in a GitHub repo https://github.com/starksm64/core/releases/tag/4.0.0-Alpha1 that is in the new namespace so when I get around to trying that I can expose a branch or get you a binary that at least compiles.
AFAIK looking at the Jenkins job it is using settings from here https://github.com/anajosep/cditck-porting whereas it probably should be running from https://github.com/eclipse-ee4j/cditck-porting not sure what the differences are.
Steve
-----Original Message-----
From: Matej Novotny <manovotn@xxxxxxxxxx>
Sent: 20 April 2020 15:16
To: glassfish developer discussions <glassfish-dev@xxxxxxxxxxx>
Cc: Steve Millidge (Payara) <steve.millidge@xxxxxxxxxxx>; Martin Kouba <mkouba@xxxxxxxxxx>
Subject: Re: [glassfish-dev] Question about nightly builds and running TCKs
Thanks for answers, few more remarks/questions:
> Hi Martin,
For future reference, the name is Matej, but no hard feelings about that ;)
> 1) Currently you will have to checkout and build master for current
> builds or take it from Jenkins which is building master
Thanks for the pointer. I realize it is unstable at this point, I just want to know where to look since Weld's master branch will only be able to test TCKs with GF for some time.
> 2) For upgrading Weld you can just copy the latest Weld jar into the
> glassfish modules directory and restart glassfish as you describe.
> However if you want to test Jakarta namespace change then there is a
> bunch of code within GlassFish that will need to be changed. I have an
> in progress branch to do these changes but is expanding day by day and
> hitting blockers on other upstream projects day by day. Currently it
> is blocked on Weld (chicken and egg).
Yes, I realize we will have to release some Weld Alpha that basically doesn't pass/test any TCKs because it has nowhere to pass them yet...
Me and Scott are working to figure other dependencies of Weld that need to be released before we can get Weld out.
I will make sure to let you guys know once the first build is out.
I suppose there is not much point in asking for the branch until you have a Weld version to integrate into GF, right? Since it won't run anyway.
> 3) Jenkins has jobs to run the TCK
Is there a way I can get access to see the job's settings? I can now only see its outcome (last build 5 months ago).
Again, since GF will be the first JEE 9 server, I will be creating a very similar run as part of CI for Weld's master branch and also as a regular sanity check as soon as there is a working Weld 4 in GF.
It would be much easier with this job as a template :)
Thanks again for your responses
Matej
----- Original Message -----
> From: "Alwin Joseph" <alwin.joseph@xxxxxxxxxx>
> To: "glassfish developer discussions" <glassfish-dev@xxxxxxxxxxx>, "Steve Millidge (Payara)"
> <steve.millidge@xxxxxxxxxxx>
> Cc: "Martin Kouba" <mkouba@xxxxxxxxxx>
> Sent: Monday, April 20, 2020 2:06:00 PM
> Subject: Re: [glassfish-dev] Question about nightly builds and running
> TCKs
>
>
>
> Hi,
>
> 3). Yes, the https://ci.eclipse.org/glassfish/job/cditck-porting is
> the pipeline job (corresponding to the Jenkinsfile ) that needs to be
> triggered to run the cdi TCK using the porting kit.
>
> Currently we can select the "CDI_PORTING_TCK" option in the job
> https://ci.eclipse.org/jakartaee-tck/job/standalonetck-nightly-build-r
> un-master to trigger the above pipeline job that will build the
> portingkit and run the cdi tck. By default, it picks the CDI TCK from
> http://download.eclipse.org/ee4j/cdi/cdi-tck-2.0.6-dist.zip .
>
>
> Regards,
> Alwin
>
> On 20/04/20 5:25 PM, Steve Millidge (Payara) wrote:
>
>
>
> Hi Martin,
>
> Some answers;
>
> 1) Currently you will have to checkout and build master for current
> builds or take it from Jenkins which is building master
> https://ci.eclipse.org/glassfish/job/glassfish/job/master/lastSuccessf
> ulBuild/artifact/bundles/glassfish.zip
> . Currently I would call this unstable as we are in the middle of
> moving to the Jakarta namespace and a number of tests fail. Our
> current test of quality for merging PRs is that the code compiles!
>
> 2) For upgrading Weld you can just copy the latest Weld jar into the
> glassfish modules directory and restart glassfish as you describe.
> However if you want to test Jakarta namespace change then there is a
> bunch of code within GlassFish that will need to be changed. I have an
> in progress branch to do these changes but is expanding day by day and
> hitting blockers on other upstream projects day by day. Currently it
> is blocked on Weld (chicken and egg).
>
> 3) Jenkins has jobs to run the TCK
> https://ci.eclipse.org/glassfish/job/cditck-porting/ I think this is
> the correct one but I'm not sure. I wasn't involved in the GlassFish
> 5.1 release so didn't set these jobs up.
>
> Perhaps someone form Oracle on the GF team is more familiar with (3).
>
> Steve
>
> -----Original Message-----
> From: glassfish-dev-bounces@xxxxxxxxxxx
> <glassfish-dev-bounces@xxxxxxxxxxx>
> On Behalf Of Matej Novotny
> Sent: 17 April 2020 09:33
> To: glassfish-dev@xxxxxxxxxxx Cc: Martin Kouba <mkouba@xxxxxxxxxx> Subject:
> [glassfish-dev] Fwd: Question about nightly builds and running TCKs
>
> Hello,
>
> I am from Weld team and I recently started looking into adapting Weld
> for Jakarta 9.
> Since GF is the only server that will early on adapt this, I will want
> to swap our testing (Jenkins) towards GF so that we have some
> incontainer test coverage.
>
> And I am missing some bits that I hope you can point me towards:
> 1) Where can I get some latest GF build and how "new" and stable is
> that build
> - basically looking for a place where jenkins can grab some
> nightly/weekly snapshot of GF to work with
>
> 2) How do you swap a component version inside; e.g. how do I upgrade
> Weld inside GF?
> - I know this used to be just about copying the osgi bundle into
> "glassfish/modules", is that still the case?
>
> 3) How do you run CDI TCK with GF?
> - we used to have a setup which leveraged weld-glassfish-runner[1]
> but that wasn't used for some time and I recall some errors last time
> I tried
> - how do you run TCKs? Is there some public jenkins job where this
> can be seen?
>
> Best regards
> Matej
> ______________________________________________________________________
> _____________________________________
> [1] https://github.com/weld/weld-glassfish-tck-runner
> _______________________________________________
> glassfish-dev mailing list glassfish-dev@xxxxxxxxxxx To unsubscribe
> from this list, visit
> https://www.eclipse.org/mailman/listinfo/glassfish-dev
> _______________________________________________
> glassfish-dev mailing list glassfish-dev@xxxxxxxxxxx To unsubscribe
> from this list, visit
> https://www.eclipse.org/mailman/listinfo/glassfish-dev
>
>
> _______________________________________________
> glassfish-dev mailing list
> glassfish-dev@xxxxxxxxxxx
> To unsubscribe from this list, visit
> https://www.eclipse.org/mailman/listinfo/glassfish-dev
>
