Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [el-dev] Mark: Thanks for acknowledging the impending release review, but wait, there's more


On Wed, Feb 21, 2024 at 4:06 AM Mark Thomas via el-dev <el-dev@xxxxxxxxxxx> wrote:
On 21/02/2024 01:00, Ed Burns via el-dev wrote:
> Arjan Tijms wrote:
>
> We do have to remember that we have really little time remaining
> to resolve this. _expression_ Language is up for review at the end of
> this month:
>
> See https://www.eclipse.org/lists/jakartaee-platform-dev/msg04409.html
> <https://www.eclipse.org/lists/jakartaee-platform-dev/msg04409.html> <https://www.eclipse.org/lists/jakartaee-platform-dev/msg04409.html <https://www.eclipse.org/lists/jakartaee-platform-dev/msg04409.html>>
>
> Mark Thomas wrote:
>
> Yep. I'm aware of that. I should have a PR for this later today.
>
> While I am relieved that Mark is aware of the release plan, I want to
> make sure Mark is also aware of new content in the Jakarta EE TCK
> Process <https://jakarta.ee/committees/specification/tckprocess/>.
> Specifically, the section “TCK types and requirements” and the text:
>
> The individual specification TCK must provide a mechanism for running
> the required TCK tests (types 1 and 3) outside the context of a platform
> or profile. Type 2 tests must be excluded and not run.
>
> Mark, does this requirement come as a surprise to you? How difficult
> would it be to comply with this requirement for EL for the release
> review at the end of the month?

While that is a surprise to me it isn't an issue for EL since the entire
test suite is type 3 since EL doesn't care whether it is running in a
Jakarta EE platform or directly on Java SE.

I'm currently looking at the EL TCK as it will probably need some tweaks
in light of the consistency changes in progress for the OptionalELResolver.

My biggest concern right now is that the signature tests aren't passing.
I think something is going wrong with the jimage extraction. It may be a
configuration issue. I'll be working on this later today.

You might try the new sigtest fork that we moved into https://github.com/eclipse-ee4j/jakartaee-tck-tools/tree/master/tools/sigtest and just released an update

<dependency>
    <groupId>jakarta.tck</groupId>
    <artifactId>sigtest-maven-plugin</artifactId>
    <version>2.1</version>
</dependency>
Regarding EL TCK https://github.com/jakartaee/platform-tck/pull/1209 was merged and could easily move into the EL Spec repo.

Scott
 

My aim is to get the EL TCK passing with Tomcat on both Java 17 and Java 21.

Mark
_______________________________________________
el-dev mailing list
el-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/el-dev

Back to the top