Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [egit-dev] checking

The commit component is also now re-used within the staging view where space is really at a premium. I'm definitely no UX expert however so perhaps there's a better solution but I do think consistency across those two elements is a good thing.

On 07/06/2011, at 5:58 AM, Chris Aniszczyk wrote:

For what it's worth, I actually like the change. It make the best use
of space IMHO... we can iterate on the dialog in 1.1 if people have
constructive criticism. It will be hard to please everyone though...

On Jun 6, 2011, at 2:53 PM, Alex Blewitt <alex.blewitt@xxxxxxxxx> wrote:

The bug is, "Please revert EGit commit dialog", raised on Wednesday last week.

Mind you, I'm pretty sure that change snuck in around the middle of last month, right before 1.0, so it's not like there was a great deal of time for anyone to see the new work and provide feedback before the 1.0 release.

commit 4429adcab409c77575fc2c206b97234607c128c5
Author: Kevin Sawicki <kevin@xxxxxxxxxx>
Date:   Thu May 19 21:43:53 2011 -0700


On 6 Jun 2011, at 16:40, Swindells, Thomas wrote:

I'd have to agree with this thread,
Looking at the screenshot ( ) I'm not even sure exactly what each of them mean and generally wouldn't notice them. Side by side would seem a good comprimize - these are just as, if not more important/useful than the author/committer details (I'd expect much fewer people to need to change from the default of these).


-----Original Message-----
From: egit-dev-bounces@xxxxxxxxxxx [mailto:egit-dev-bounces@xxxxxxxxxxx ]
On Behalf Of Robert Munteanu
Sent: 06 June 2011 15:22
To: Alex Blewitt
Cc: EGit developer discussion
Subject: Re: [egit-dev] checking

On Sun, Jun 5, 2011 at 11:09 AM, Alex Blewitt <alex.blewitt@xxxxxxxxx >
On 4 Jun 2011, at 23:49, Matthias Sohn <matthias.sohn@xxxxxxxxxxxxxx >

The checkboxes were replaced by toggle buttons which isn't really
hiding them but leaving some more space for the commit message and
the file list.

Yeah, that's the awful UI I was talking about. Everyone knows what a
checkbox means on platforms and can read the explanatory text to learn how to use the UI. No one knows what a small icon is for, and so won't be able to learn how to use it unless they already know. Which is a checkbox and
which is an action? A UI is supposed to be intuitive.

I recently noticed the new and noteworthy screenshots as well, and I think
that the icons might be a little too obscure to be of real use.
I believe that introducing the checkboxes in a 2x2 grid would've reduced the
space taken up by 50% which should be a good enough saving.

Alex, you mentioned a bug report. Can you please link to it? I hope that even though we're going to ship 1.0 with the current Commit Dialog layout there is
room for discussion on its future form.



Frankly the UI for EGit's commits sucks in the name of "needing more space
for the commit message". I mean really? Scrolling is a technique when these things overflow - what you've saved is maybe one or two lines and made it significantly worse for the new user, not to mention breaking style guidelines
and consistency with every other version control commit dialog.

No doubt it's too late to do anything about it now; maybe it wasn't when I
raised the bug about it earlier on. But I will say it on record that my belief is that this was a badly executed change (from a UX perspective) with minimal benefit (optimising for a specific case when there is between old- new lines
of text shown).

egit-dev mailing list

Sent from my (old) computer
egit-dev mailing list

This message is confidential and intended only for the addressee. If you have received this message in error, please immediately notify the postmaster@xxxxxxx and delete it from your system as well as any copies. The content of e-mails as well as traffic data may be monitored by NDS for employment and security purposes. To protect the environment please do not print this e-mail unless necessary.

NDS Limited. Registered Office: One London Road, Staines, Middlesex, TW18 4EX, United Kingdom. A company registered in England and Wales. Registered no. 3080780. VAT no. GB 603 8808 40-00

egit-dev mailing list
egit-dev mailing list

Back to the top