Re: [eclipse-pmc] Request API change for ProjectConfigurator

[Lars Vogel <lars.vogel@xxxxxxxxxxx>]

+1 for this change after the review is finished by Markus, who gave
feedback to the change.

On Tue, Mar 29, 2016 at 11:30 AM, Lars Vogel <lars.vogel@xxxxxxxxxxx> wrote:
> Hi Mickael,
>
> Just in case you are wondering why you did not receive an answer,
> today is the next PMC meeting and I think after this meeting you will
> get a response.
>
> Best regards, Lars
>
> On Fri, Mar 25, 2016 at 6:22 PM, Mickael Istria <mistria@xxxxxxxxxx> wrote:
>> Hi all,
>>
>> By M5, I merged an API that does not conform to Eclipse standard of quality.
>> I was too focused on the UI parts and forgot some basic checks regarding
>> APIs, and the size of the review on Gerrit made that reviewers also missed
>> this. I'm sorry about that, and I take full responsibility for that, and
>> I'll for sure do my best in avoiding to do it again.
>> In order to fix those issues in this API, I'd like to get this change
>> included by M7: https://git.eclipse.org/r/#/c/69249/ . It consists of:
>> * Better documentation
>> * Removal of a deprecated method
>> * Addition of a new method, which has a default set, just in case.
>> Any feedback is welcome, ideally on the Gerrit review for the most technical
>> parts.
>> Currently, there is no project at Eclipse.org nor out of Eclipse.org who has
>> adopted this API in their master branch, and despite being in M5, this API
>> has not been "announced" yet. I've already submitted some reviews in
>> different projects, and have those upcoming adopters to work with both M5
>> version and proposed M6 version (mainly by removing the @Override
>> annotation). So it seems like the impact of that change is minor and not
>> putting Eclipse 4.6.M7 nor its adopters at risk.
>>
>> Would the PMC agree with such change?
>> Cheers,
>> --
>> Mickael Istria
>> Eclipse developer at JBoss, by Red Hat
>> My blog - My Tweets
>>
>>
>> _______________________________________________
>> eclipse-pmc mailing list
>> eclipse-pmc@xxxxxxxxxxx
>> To change your delivery options, retrieve your password, or unsubscribe from
>> this list, visit
>> https://dev.eclipse.org/mailman/listinfo/eclipse-pmc
>
>
>
> --
> Eclipse Platform UI and e4 project co-lead
> CEO vogella GmbH
>
> Haindaalwisch 17a, 22395 Hamburg
> Amtsgericht Hamburg: HRB 127058
> Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
> USt-IdNr.: DE284122352
> Fax (040) 5247 6322, Email: lars.vogel@xxxxxxxxxxx, Web: http://www.vogella.com



-- 
Eclipse Platform UI and e4 project co-lead
CEO vogella GmbH

Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
USt-IdNr.: DE284122352
Fax (040) 5247 6322, Email: lars.vogel@xxxxxxxxxxx, Web: http://www.vogella.com