Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [che-dev] Incompatible change in devfile format

https://github.com/che-incubator/chectl/pull/159

On 11. 06. 19 22:11, Lukas Krejci wrote:
No, I have not! Apologies, didn't know about such functionality in chectl.


On 11. 06. 19 21:50, Sun Tan wrote:
hello Lukas,
Have we updated chectl devfile:generate so it generates the right fields ?


Sun Tan

Senior Software Engineer

*Eclipse Che - CodeReady Workspaces *@ Red Hat
*Paris JUG leader*

Red Hat Paris <https://www.redhat.com/>

sutan@xxxxxxxxxx
M: +33621024173
@sunsengdavidtan <https://twitter.com/sunsengdavidtan>   me
<https://www.linkedin.com/in/sun-seng-david-tan-b05a684/>
<https://www.redhat.com/>


On Fri, Jun 7, 2019 at 9:29 PM Mario <mario.loriedo@xxxxxxxxx> wrote:



On Fri, Jun 7, 2019, 20:48 Sergii Kabashniuk <skabashn@xxxxxxxxxx> wrote:

What if we do that right now? With Likas's changes?
I think that is the last breaking changes that we are planning before GA.


+1



On Fri, Jun 7, 2019 at 9:31 PM Mario <mario.loriedo@xxxxxxxxx> wrote:

That's not a silly question at all. We are technically in beta and we
don't support older versions of the spec. That explains why we are not
incrementing it yet. But for the GA we should probably think about bumping
the version to 1.0.0.

On Fri, Jun 7, 2019, 20:13 Dave Neary <dneary@xxxxxxxxxx> wrote:

Hi,

This might be a silly question, but whi is apiVersion not being
incremented with each of these incompatible changes?

Thanks,
Dave.

On 07/06/2019 12:09, Lukas Krejci wrote:
Hi all,

This change affects ALL existing devfiles but we hope it is for the
better.

In order to align the devfile format with Kubernetes conventions more
(and to open the door for devfile possibly becoming a CRD in the
future), we're making the following simple yet important changes:

* 'specVersion' attribute is being renamed to 'apiVersion'
* 'name' attribute is being moved under a new 'metadata' key

So the old devfile starting with the usual snippet:

specVersion: 0.0.1
name: acme-devfile
...

will have to change to:

apiVersion: 0.0.1
metadata:
   name: acme-devfile
...


This change is slated for the next milestone of Che 7 and you can
track
the progress in the PR https://github.com/eclipse/che/pull/13490.

Hope it doesn't cause too much trouble for you.

With regards,

Lukas Krejci

_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or
unsubscribe
from this list, visit
https://www.eclipse.org/mailman/listinfo/che-dev

--
Dave Neary - Eclipse Che Ecosystem & Community Manager
Open Source and Standards - Red Hat
E: dneary@xxxxxxxxxx / T: @nearyd / Ph: +1-978-799-3338
_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://www.eclipse.org/mailman/listinfo/che-dev

_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://www.eclipse.org/mailman/listinfo/che-dev



--

Sergii Kabashniuk

Principal Software Engineer, DevTools

Red Hat Ukraine

skabashniuk@xxxxxxxxxx
_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://www.eclipse.org/mailman/listinfo/che-dev

_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://www.eclipse.org/mailman/listinfo/che-dev



_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/che-dev



Back to the top