Re: [cdt-dev] Committing through Gerrit

[Marc Khouzam <marc.khouzam@xxxxxxxxxxxx>]

> -----Original Message-----
> From: cdt-dev-bounces@xxxxxxxxxxx 
> [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Sergey Prigogin
> Sent: Monday, September 17, 2012 3:03 PM
> To: CDT General developers list.
> Subject: Re: [cdt-dev] Committing through Gerrit
> 
> I find committing through Gerrit risky since CDT Gerrit is 
> not hooked up into Hudson for running tests. 

I enjoy the one-click commit from Gerrit.  But before that
is done the code really should be "Fetch from Gerrit" and
tested by the approver (unless the review is for another
committer and is just a code review without testing).
So normally, the tests should be run before the final
commit is done.

> 
> -sergey
> 
> 
> On Mon, Sep 17, 2012 at 12:00 PM, Doug Schaefer 
> <dschaefer@xxxxxxx> wrote:
> 
> 
> 	That's a good idea. BTW, I thought that's what the 
> difference between +1
> 	and +2 was. +1 means you're OK with the change but you 
> need to +2 to
> 	actually commit it, no?
> 	
> 	D
> 	
> 
> 	On 12-09-17 2:56 PM, "Marc Khouzam" 
> <marc.khouzam@xxxxxxxxxxxx> wrote:
> 	
> 	>
> 	>Hi committers,
> 	>
> 	>as our use of Gerrit increases I thought I'd mention a 
> practice we've
> 	>been doing in Debug.
> 	>When a committer reviews code from another committer, 
> we let the original
> 	>committer do the
> 	>actual commit.
> 	>
> 	>Therefore, in Gerrit, the reviewing committer would 
> use the "Publish
> 	>Comments" button
> 	>and would leave the original committer to go to Gerrit 
> and press "Publish
> 	>and Submit".
> 	>That way, committers get to commit their own changes.
> 	>
> 	>I'm not sure if this practice is done throughout the 
> CDT or not but I
> 	>thought I would
> 	>suggest it as a good practice if others agree.
> 	>
> 	>Thanks
> 	>
> 	>Marc
> 	>
> 	>
> 	>
> 	>_______________________________________________
> 	>cdt-dev mailing list
> 	>cdt-dev@xxxxxxxxxxx
> 	>https://dev.eclipse.org/mailman/listinfo/cdt-dev
> 	
> 	_______________________________________________
> 	cdt-dev mailing list
> 	cdt-dev@xxxxxxxxxxx
> 	https://dev.eclipse.org/mailman/listinfo/cdt-dev
> 	
> 
> 
>