Re: [cdt-dev] Committing through Gerrit

[Sergey Prigogin <eclipse.sprigogin@xxxxxxxxx>]

I find committing through Gerrit risky since CDT Gerrit is not hooked up into Hudson for running tests.

-sergey

On Mon, Sep 17, 2012 at 12:00 PM, Doug Schaefer <dschaefer@xxxxxxx> wrote:

That's a good idea. BTW, I thought that's what the difference between +1
and +2 was. +1 means you're OK with the change but you need to +2 to
actually commit it, no?

D

On 12-09-17 2:56 PM, "Marc Khouzam" <marc.khouzam@xxxxxxxxxxxx> wrote:

>
>Hi committers,
>
>as our use of Gerrit increases I thought I'd mention a practice we've
>been doing in Debug.
>When a committer reviews code from another committer, we let the original
>committer do the
>actual commit.
>
>Therefore, in Gerrit, the reviewing committer would use the "Publish
>Comments" button
>and would leave the original committer to go to Gerrit and press "Publish
>and Submit".
>That way, committers get to commit their own changes.
>
>I'm not sure if this practice is done throughout the CDT or not but I
>thought I would
>suggest it as a good practice if others agree.
>
>Thanks
>
>Marc
>
>
>
>_______________________________________________
>cdt-dev mailing list
>cdt-dev@xxxxxxxxxxx
>https://dev.eclipse.org/mailman/listinfo/cdt-dev

_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cdt-dev