[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [birt-dev] 4.7.0 : Missing schema file for ScriptEngineFactory extension point

On Wed, Jul 12, 2017 at 12:51 PM, Zorawar S.B. <zorawar.e@xxxxxxxxx> wrote:

Please see the attached image.
The schema file for ScriptEngineFactory extension point is not present in the artifact org.eclipse.birt.core_4.7.0.v*.jar. It is also not present under the schema folder for the 4.7.0 runtime. The master onÂhttps://github.com/eclipse/birt/tree/master/core/org.eclipse.birt.core/schema does have it though.Â
Seems like a packaging issue.
I thought to check here before raising a bug report.


I have submitted a bug-report[1] and a pull-request[2] for this issue.
After going through the code and debugging I found that birt/core/org.eclipse.birt.core/build.properties did not include entry for the schema file.
It seemed like a simple fix. However, I would like to get feedback on it if there is any place else that requires checking.
[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=520124
[2] https://github.com/eclipse/birt/pull/409

After the build, the org.eclipse.birt.core_4.7.0*.jar has the schema file.

This is my first time contributing to the project.
Please point me to the necessary things I need to do to have the fix submitted.


Attachment: added-missing-schema-file.png
Description: PNG image