Re: [wakaama-dev] Wakaama and Erbium

[Benjamin Cabé <benjamin@xxxxxxxxxxx>]

Also, as a reminder, Erbium is strictly speaking a 3^rd party dependency, so it is not expected that its codebase should be modified, or if it is, a new CQ should be filed.

 

Benjamin.

 

De : <wakaama-dev-bounces@xxxxxxxxxxx> au nom de Julien Vermillard <jvermillard@xxxxxxxxx>
Répondre à : Wakaama developer discussions <wakaama-dev@xxxxxxxxxxx>
Date : lundi 12 décembre 2016 à 16:24
À : Wakaama developer discussions <wakaama-dev@xxxxxxxxxxx>
Objet : Re: [wakaama-dev] Wakaama and Erbium

 

HI,

I don't know why Erbium was modified, I think only David knows.

--
Julien Vermillard

 

On Fri, Dec 2, 2016 at 5:08 PM, Simon Bernard <sbernard@xxxxxxxxxxxxxxxxxx> wrote:

Hi,

   I'm still looking at block2 in wakaama. It seems that most of the code of packet.c[1] was largely inspired from coap erbium[2]. I try to understand the utilily of new_offset and block_offset variables. I suspect that thoses variables were inherited from erbium and now new_offset is no more needed because of modification done in wakaama[3]. (offset is no more an output parameter of handle_request/service_cbk function)

   All of this bring me to this question :
   Why wakaama does not use an unmodified version of erbium ?

Thx,

Simon

[1]https://github.com/eclipse/wakaama/blob/master/core/packet.c#L200
[2]https://github.com/contiki-os/contiki/blob/master/apps/er-coap/er-coap-engine.c#L67
[3]https://github.com/eclipse/wakaama/commit/eba89734979b5d0a95e86fd61b4c3cc628f3cca8#diff-3fe00c877ce79eb0a45eba1cb72d9712L198

_______________________________________________
wakaama-dev mailing list
wakaama-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/wakaama-dev

 

_______________________________________________ wakaama-dev mailing list wakaama-dev@xxxxxxxxxxx To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/wakaama-dev