Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [rdf4j-dev] SparqlComplianceTest

Not fully sure either, but I think this is because in the dim past we had both the official W3C-approved tests and our own tests, and we used the same manifest-based mechanism to capture both. So testcases-sparql-1.1/ is a mix of both our own and the official tests.

At some point we moved away from that because using the manifest format for testing was a bit painful. So we now have testcases-sparql-1.1-w3c/ as the official W3C-approved set of (manifest based) tests, but we do our own compliance testing using the ComplexSPARQLQueryTest set of tests (which was actually recently renamed and reorganized to RepositoryComplianceSPARQLTestSuite).

Mind you, this is all in the dim past, so I may have some of the details wrong. I don't think we've used that old manifest since we moved to Eclipse and became RDF4J.

Regardless, we should probably do some cleanup here and write some documentation for third party implementors that want to reuse our test suite.

Jeen

On Tue, 14 Jun 2022, at 07:09, Håvard Ottestad wrote:
Looks like the Halyard tests are referring to "testcases-sparql-1.1/manifest-evaluation.ttl" which we don't seem to be using anywhere. I'm not sure why we aren't using them. 

Do you know Jeen?

Cheers,
Håvard


On 13 Jun 2022, at 20:19, Matthew Nguyen <nguyenm9@xxxxxxx> wrote:

Hi, these were the two that failed in 4.x but not 3.7.x


"sparql11-sum-03",
"sparql11-sum-04" Could you let me know which tests/module in RDF4J are exercising this class so I can try and debug? I see them in rdf4j-sparql-testsuite but not sure how/when they're invoked.


-----Original Message-----
From: Håvard Ottestad <hmottestad@xxxxxxxxx>
To: Matthew Nguyen <nguyenm9@xxxxxxx>; rdf4j developer discussions <rdf4j-dev@xxxxxxxxxxx>
Sent: Mon, Jun 13, 2022 9:59 am
Subject: Re: [rdf4j-dev] SparqlComplianceTest


Hi Matthew,

RDF4J uses those tests. Could be a buggy test, or there could be a bug in Halyard. Even though the test might not have changed between 3.7.x and 4.0.0 it might be that Halyard is extending a class from RDF4J that has changed in 4.0.0. 

I have seen that our handling of tests for queries with the REDUCED keyword is somewhat poorly implemented. Is that the test that is failing for you?


Håvard

On 13 Jun 2022, at 14:50, Matthew Nguyen via rdf4j-dev <rdf4j-dev@xxxxxxxxxxx> wrote:


Hi, I'm working on an implementation derived from this codebase (https://github.com/pulquero/Halyard) and trying to upgrade to RDF4J 4.x.  I've noticed that 2 additional tests have failed using these tests under 4.x and wonder if baseline RDF4J is running against these tests (SPARQLQueryComplianceTesting) at all (https://github.com/pulquero/Halyard/blob/latest/strategy/src/test/java/com/msd/gin/halyard/strategy/HalyardSPARQLQueryTest.java#L43)

Looking over the RDF4J 4.x codebase, I don't see anything deriving from these abstract base classes so wanted to see if they were being engaged another way and if these failure were expected in 4.x?
_______________________________________________
rdf4j-dev mailing list
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/rdf4j-dev
_______________________________________________
rdf4j-dev mailing list
rdf4j-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/rdf4j-dev



Back to the top