Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [rdf4j-dev] Collection Factory GH-3843 how to configure?
Hi Jerven,

I haven't really found time yet to look at your PR in more detail, apologies for that. I'll try and put some time into this over the weekend (but can't promise anything, I'm in between house moves at the moment so it's all a little chaotic).

Rough kneejerk thoughts on the idea:
  1.  I can totally understand that each Sail implementation can make more optimal choices regarding how to collect/persist its own values, but why does that need to be anything other than an internal matter for the sail? In other words: who are the intended users of these publicly exposed collections and collection factories?
  2. I am very way of adding any methods (even with default implementations) to the base Sail interfaces, as it adds implementation responsibilities on third parties, and also just makes the interfaces harder to understand. I'd much rather add a new behavioral interface with this method, and have our sail implementations derive from that new interface (alongside the Sail interface).
Take the above with several grains of salt as (like I said) I haven't really had time to look at your PR in detail. I think the main thing for me is a better understanding of the motivation and use cases.

Cheers,

Jeen

On Fri, 10 Jun 2022, at 20:57, jerven Bolleman wrote:
Hi All,

I wanted some feedback on GH-3843 [1]. Specifically on how best to 
configure these kinds of factories.

So the idea of this issue is that we can build Collection classes that
use specific knowledge of a store's value implementations to be faster 
and use less memory.

Now I think my pull request shows the benefits. But it also leads to the 
collection-factory to be configurable. e.g. using MapDB or soon LMDB. It 
also allows a better implementation of [2] or even removal as it is no 
longer needed.

So regarding this configuration: I am very not at all experienced with 
the rdf files used to configure rdf4j server etc. and I would like some 
help/pointers in how to best implement this.

Regards,
Jerven

[1] https://github.com/eclipse/rdf4j/pull/3844
[2] https://github.com/eclipse/rdf4j/issues/3983
-- 

*Jerven Tjalling Bolleman*
Principal Software Developer
*SIB | Swiss Institute of Bioinformatics*
1, rue Michel Servet - CH 1211 Geneva 4 - Switzerland
t +41 22 379 58 85
Jerven.Bolleman@sib.swiss - www.sib.swiss

_______________________________________________
rdf4j-dev mailing list
rdf4j-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/rdf4j-dev


Back to the top