Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [platform-dev] Proposal for StyledText
This is noise. As said before. Let's discuss in the bug report.

Dani



From:        Wim Jongman <wim.jongman@xxxxxxxxx>
To:        "Eclipse platform general developers list." <platform-dev@xxxxxxxxxxx>
Date:        14.12.2018 19:42
Subject:        Re: [platform-dev] Proposal for StyledText
Sent by:        platform-dev-bounces@xxxxxxxxxxx



Hey,

I think that the switch should be a style bit. WDYT?

Best regards,

Wim


On Fri, 14 Dec 2018, 16:06 Daniel Megert <daniel_megert@xxxxxxxxxxwrote:
Hi Laurent

We look forward for such a contribution. As mentioned before, StyledText is a custom widget, hence it should be doable for all platforms. I agree that it should be disabled by default, and I also agree that we can discuss this further in the bug report.

> For the moment, I'm gonna clean the code, fill a bug and propose the patch.
==> https://bugs.eclipse.org/542777

Dani



From:        Laurent Caron <laurent.caron@xxxxxxxxx>
To:        platform-dev@xxxxxxxxxxx
Date:        13.12.2018 18:50
Subject:        Re: [platform-dev] Proposal for StyledText
Sent by:        platform-dev-bounces@xxxxxxxxxxx



Hi Mickael and Thomas,

Thank you for your feedback. For the moment, I'm gonna clean the code, fill a bug and propose the patch.
Let's see what happen.

For Mickael : thank you for the tip. I'll be patient and if my patch is not accepted it's not a problem, it was funny to develop.

Laurent

Le jeu. 13 déc. 2018 à 12:00, Mickael Istria <mistria@xxxxxxxxxx> a écrit :
On Thu, Dec 13, 2018 at 11:54 AM Thomas Singer <ts-swt@xxxxxxxxxxx> wrote:

I'd prefer it to be optional, because the StyledText might be used in
situations where this behavior might be unexpected. IMHO the best
approach would be to make it not part of the official StyledText (if
possible), but instead implement it to a separate class without the
StyledText class knowing about it. If this is not possible, please
implement it that way that it needs to be enabled for each StyledText
instance individually.



I think we can discuss that kind of things once we have a 1st version of the patch. Depending on the implementation, there could be various ways to approach the enabled/disabled issue, it's too early to find out the best one IMO and we should first get a patch that enables/disables with an explicit flag (with something like StyledText.enableButton3Scroll(button)) and then we'll be more able to discuss the default value.

Do you happen to maintain one of such StyledText that would be negatively impacted by this feature?

_______________________________________________
platform-dev mailing list
platform-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/platform-dev_______________________________________________
platform-dev mailing list
platform-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/platform-dev


_______________________________________________
platform-dev mailing list
platform-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/platform-dev_______________________________________________
platform-dev mailing list
platform-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/platform-dev


Back to the top