[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [mylyn-dev] Review of EPUB support in Mylyn Docs
|
Thanks for helping to debug this. It looks like org.eclipse.mylyn/org.eclipse.mylyn-parent/pom.xml was indeed missing environment entries for macos. I have added them to the parent pom and deployed a new snapshot.
Steffen
On Wed, Oct 5, 2011 at 11:41 PM, Torkild Ulvøy Resheim
<torkildr@xxxxxxxxx> wrote:
Hi Steffen,
Yes, the OS X profile appears to be activated. I get:
Active Profiles for Project 'org.eclipse.mylyn:org.eclipse.mylyn-parent:pom:3.7.0-SNAPSHOT':
The following profiles are active:
- default-target (source: pom)
- implicit-target (source: pom)
- osx (source: pom)
vmargs looked good but I forced them anyway and got the same result. Log file from "mvn -X ..." coming in a separate e-mail as soon as it's done.
Best regards,
Torkild
Den 5. okt. 2011 kl. 23:10 skrev Steffen Pingel:
Hi Torkild,
can you try running "mvn help:active-profiles" in org.eclipse.mylyn/org.eclipse.mylyn-parent? I am curious if the osx profile actually gets activated.
Otherwise you could also try forcing the the vmargs: "mvn '-Dtest.vmargs=-Dosgi.ws=cocoa -XstartOnFirstThread' ...". If that fails, could you run tests with "mvn -X ..." and send me the output (privately)?
Thanks!
Steffen
On Wed, Oct 5, 2011 at 11:01 PM, Torkild Ulvøy Resheim
<torkildr@xxxxxxxxx> wrote:
Thanks Steffen,
I'll take a look at using JUnit4 again when time permits. The EPUB tests are executing fine now. However the o.e.m.wikitext.tests does not. It appears that the OS X SWT bundles are not included in the dependencies. Log file attached (I don't know if it will make it through the list server).
I've also done some adjustments to building the documentation so that Maven will pass along the dependencies used for building in order to construct a classpath for the Ant tasks that are executed in a separate script. Hence I don't have to pollute the pom.xml with Ant stuff and there is no need to build the WikiText parts for the sole purpose of generating documentation. It works nicely for generating the Eclipse help, but not for the EPUB. It appears that it is not able to put together all the dependencies for org.eclipse.emf.ecore.resource.ResourceSet. Which is a bit strange as I am able to build using the same classpath. Anyway, as was not intended to be a part of the distribution I'll move it to a separate "examples" bundle.
Best regards,
Torkild
Den 5. okt. 2011 kl. 00:09 skrev Steffen Pingel:
> It should be sufficient to depend on org.junit4 or
> org.junit;bundle-version="4.0.0" in the manifest of the test plug-in
> to configure Tycho to use JUnit4
> (https://bugs.eclipse.org/bugs/show_bug.cgi?id=353222#c9).
>
> Running o.e.m.wikitext.tests from the command line works for me:
>
> org.eclipse.mylyn.docs/org.eclipse.mylyn.wikitext.tests$ mvn integration-test
> [INFO] Scanning for projects...
> [INFO] Resolving target platform for project MavenProject:
> org.eclipse.mylyn.docs:org.eclipse.mylyn.wikitext.tests:1.6.0-SNAPSHOT
> @ /home/spingel/mylyn/src/org.eclipse.mylyn.docs/org.eclipse.mylyn.wikitext.tests/pom.xml
> [INFO] Adding repository...
> [...]
>
> Results :
>
> Tests run: 768, Failures: 0, Errors: 0, Skipped: 0
>
> [INFO] All tests passed!
> ...
>
> If you get errors about unresolved dependencies install the latest
> Mylyn Docs bundles into your local Maven repository before running
> tests:
>
> org.eclipse.mylyn.docs$ mvn install -Dmaven.test.skip=true
>
> If you have all dependency cached locally you can run mvn with
> --offline to make it run faster.
>
> If it doesn't work on your platform, can you run with -X and send me
> the logfile? We might still be missing some of the parameters when
> running on non Linux platforms (e.g. Mac requires
> "-XstartOnFirstThread" as a VM argument).
>
> Steffen
>
>
> On Sat, Oct 1, 2011 at 10:12 PM, Torkild Ulvøy Resheim
> <torkildr@xxxxxxxxx> wrote:
>> Thanks Steffen,
>>
>> I'm nearly done with rewriting, so there's no urgency. However at some time I'd like to know how I can use Junit4 with Maven/Tycho – so maybe a nice page at the Mylyn Wiki? Surprisingly (to me at least) Maven 3 actually comes with the X Code distribution so I've been able to run builds locally with very little effort.
>>
>> As a side note, the tests in "org.eclipse.mylyn.wikitext.tests" does not run in my local environment – throwing exceptions similar to what I got initially on the EPUB tests. It would be nice to be able to execute these locally too. I'll have a look as soon as time permits.
>>
>> Best regards,
>> Torkild
>>
>> Den 1. okt. 2011 kl. 21:49 skrev Steffen Pingel:
>>
>>> Tycho should support JUnit 3 as well as JUnit4 if you set the version
>>> constracints accordingly. Let me know if you need any help with
>>> configuring that.
>>>
>>> Steffen
>>>
>>>
>>> On Sat, Oct 1, 2011 at 8:53 PM, Torkild Ulvøy Resheim
>>> <torkildr@xxxxxxxxx> wrote:
>>>> Thanks David,
>>>> That's makes sense. I've started on making the separate bundle work. However
>>>> it appears that only JUnit 3 is supported so I'll probably have to rewrite
>>>> the test classes a bit. Looking around on the net it seems that a few others
>>>> have had the same problem, but I could not find another solution.
>>>> Best regards,
>>>> Torkild
>>>> Den 30. sep. 2011 kl. 22:36 skrev David Green:
>>>>
>>>> Torkild,
>>>> I recommend that you keep the EPUB tests separate, since the new bundles add
>>>> dependencies to emf that are not present in the rest of the WikiText
>>>> framework. This will enable committers and contributors to work on WikiText
>>>> without having modeling dependencies installed.
>>>> David
>>>>
>>>> On Thu, Sep 29, 2011 at 2:15 PM, Torkild Ulvøy Resheim <torkildr@xxxxxxxxx>
>>>> wrote:
>>>>>
>>>>> Thanks Steffen,
>>>>>
>>>>> The build looks good now except the tests are not executed. These are all
>>>>> headless so I guess there is no need for a special harness. However I
>>>>> noticed that all other tests are placed in org.eclipse.mylyn.wikitext.tests,
>>>>> taking advantage of the rigging there. Should I move the EPUB tests there or
>>>>> is there another, more straightforward option? I've looked at
>>>>> http://wiki.eclipse.org/Tycho/Reference_Card#Test_bundles which suggests
>>>>> another approach.
>>>>>
>>>>> As a side note I really have to take a closer look at Hudson/Maven/Tycho,
>>>>> It's certainly a step up from PDE Build/Ant!
>>>>>
>>>>> Best regards,
>>>>> Torkild
>>>>>
>>>>> Den 29. sep. 2011 kl. 22:32 skrev Steffen Pingel:
>>>>>
>>>>>> Great to hear! I have abandoned the old review.
>>>>>>
>>>>>> It looks like you have to add the new modules to the pom.xml that is
>>>>>> in the root folder of the git repository.
>>>>>>
>>>>>> Steffen
>>>>>>
>>>>>>
>>>>>> On Thu, Sep 29, 2011 at 10:19 PM, Torkild Ulvøy Resheim
>>>>>> <torkildr@xxxxxxxxx> wrote:
>>>>>>> Hi all,
>>>>>>>
>>>>>>> As you may have noticed it looks like I finally found a usable workflow
>>>>>>> for committing to the Mylyn Gerrit instance. I managed to botch up the first
>>>>>>> attempt so I would like the review to take place on
>>>>>>> http://review.mylyn.org/#change,61 instead of
>>>>>>> http://review.mylyn.org/#change,36. The latter can be abandoned. I started
>>>>>>> on change 61 by checking out from Gerrit and merging in only the
>>>>>>> org.eclipse.mylyn.docs.epub.* folders.
>>>>>>>
>>>>>>> I've been paying attention to the Hudson build logs and it appears that
>>>>>>> it does not pick up and build (and test) the new bundles. What can I do to
>>>>>>> remedy that?
>>>>>>>
>>>>>>> Best regards,
>>>>>>> Torkild
>>>>>>> _______________________________________________
>>>>>>> mylyn-dev mailing list
>>>>>>> mylyn-dev@xxxxxxxxxxx
>>>>>>> https://dev.eclipse.org/mailman/listinfo/mylyn-dev
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Steffen Pingel
>>>>>> Committer, http://eclipse.org/mylyn
>>>>>> Senior Developer, http://tasktop.com
>>>>>> _______________________________________________
>>>>>> mylyn-dev mailing list
>>>>>> mylyn-dev@xxxxxxxxxxx
>>>>>> https://dev.eclipse.org/mailman/listinfo/mylyn-dev
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> mylyn-dev mailing list
>>>>> mylyn-dev@xxxxxxxxxxx
>>>>> https://dev.eclipse.org/mailman/listinfo/mylyn-dev
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> David Green
>>>> VP of Engineering, Tasktop
>>>> Committer, Eclipse Mylyn
>>>> http://tasktop.com
>>>> +1-778-588-6896 ext. 115
>>>>
>>>> _______________________________________________
>>>> mylyn-dev mailing list
>>>> mylyn-dev@xxxxxxxxxxx
>>>> https://dev.eclipse.org/mailman/listinfo/mylyn-dev
>>>>
>>>>
>>>> _______________________________________________
>>>> mylyn-dev mailing list
>>>> mylyn-dev@xxxxxxxxxxx
>>>> https://dev.eclipse.org/mailman/listinfo/mylyn-dev
>>>>
>>>>
>>>
>>>
>>>
>>> --
>>> Steffen Pingel
>>> Committer, http://eclipse.org/mylyn
>>> Senior Developer, http://tasktop.com
>>> _______________________________________________
>>> mylyn-dev mailing list
>>> mylyn-dev@xxxxxxxxxxx
>>> https://dev.eclipse.org/mailman/listinfo/mylyn-dev
>>
>>
>> _______________________________________________
>> mylyn-dev mailing list
>> mylyn-dev@xxxxxxxxxxx
>> https://dev.eclipse.org/mailman/listinfo/mylyn-dev
>>
>>
>
>
>
> --
> Steffen Pingel
> Committer, http://eclipse.org/mylyn
> Senior Developer, http://tasktop.com
> _______________________________________________
> mylyn-dev mailing list
> mylyn-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/mylyn-dev
_______________________________________________
mylyn-dev mailing list
mylyn-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/mylyn-dev
--
Steffen Pingel
Committer, http://eclipse.org/mylyn
Senior Developer, http://tasktop.com
_______________________________________________
mylyn-dev mailing list
mylyn-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/mylyn-dev
_______________________________________________
mylyn-dev mailing list
mylyn-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/mylyn-dev
--
Steffen Pingel
Committer,
http://eclipse.org/mylynSenior Developer,
http://tasktop.com
