Re: [mylyn-dev] Review of EPUB support in Mylyn Docs

[Torkild Ulvøy Resheim <torkildr@xxxxxxxxx>]

Thanks David,

That's makes sense. I've started on making the separate bundle work. However it appears that only JUnit 3 is supported so I'll probably have to rewrite the test classes a bit. Looking around on the net it seems that a few others have had the same problem, but I could not find another solution.

Best regards,

Torkild

Den 30. sep. 2011 kl. 22:36 skrev David Green:

Torkild,

I recommend that you keep the EPUB tests separate, since the new bundles add dependencies to emf that are not present in the rest of the WikiText framework.  This will enable committers and contributors to work on WikiText without having modeling dependencies installed.

David

On Thu, Sep 29, 2011 at 2:15 PM, Torkild Ulvøy Resheim <torkildr@xxxxxxxxx> wrote:

Thanks Steffen,

The build looks good now except the tests are not executed. These are all headless so I guess there is no need for a special harness. However I noticed that all other tests are placed in org.eclipse.mylyn.wikitext.tests, taking advantage of the rigging there. Should I move the EPUB tests there or is there another, more straightforward option? I've looked at http://wiki.eclipse.org/Tycho/Reference_Card#Test_bundles which suggests another approach.

As a side note I really have to take a closer look at Hudson/Maven/Tycho, It's certainly a step up from PDE Build/Ant!

Best regards,
Torkild

Den 29. sep. 2011 kl. 22:32 skrev Steffen Pingel:

> Great to hear! I have abandoned the old review.
>
> It looks like you have to add the new modules to the pom.xml that is
> in the root folder of the git repository.
>
> Steffen
>
>
> On Thu, Sep 29, 2011 at 10:19 PM, Torkild Ulvøy Resheim
> <torkildr@xxxxxxxxx> wrote:
>> Hi all,
>>
>> As you may have noticed it looks like I finally found a usable workflow for committing to the Mylyn Gerrit instance. I managed to botch up the first attempt so I would like the review to take place on http://review.mylyn.org/#change,61 instead of http://review.mylyn.org/#change,36. The latter can be abandoned. I started on change 61 by checking out from Gerrit and merging in only the org.eclipse.mylyn.docs.epub.* folders.
>>
>> I've been paying attention to the Hudson build logs and it appears that it does not pick up and build (and test) the new bundles. What can I do to remedy that?
>>
>> Best regards,
>> Torkild
>> _______________________________________________
>> mylyn-dev mailing list
>> mylyn-dev@xxxxxxxxxxx
>> https://dev.eclipse.org/mailman/listinfo/mylyn-dev
>>
>>
>
>
>
> --
> Steffen Pingel
> Committer, http://eclipse.org/mylyn
> Senior Developer, http://tasktop.com
> _______________________________________________
> mylyn-dev mailing list
> mylyn-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/mylyn-dev

_______________________________________________
mylyn-dev mailing list
mylyn-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/mylyn-dev

--

David Green

VP of Engineering, Tasktop

Committer, Eclipse Mylyn

http://tasktop.com 

+1-778-588-6896 ext. 115

_______________________________________________
mylyn-dev mailing list
mylyn-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/mylyn-dev

Attachment: smime.p7s
Description: S/MIME cryptographic signature