| Re: [jgit-dev] [egit-dev] HistogramDiff now live on egit.eclipse.org |
On Oct 27, 2010 3:17 PM, "Matthias Sohn" <matthias.sohn@xxxxxxxxxxxxxx> wrote:
>
> 2010/10/28 Chris Aniszczyk <caniszczyk@xxxxxxxxx>
>
>> On Wed, Oct 27, 2010 at 4:06 PM, Matthias Sohn
>> <matthias.sohn@xxxxxxxxxxxxxx> wrote:
>> > Here is another case where the new diff fails: instead of showing just the
>> > addition of the method testDeleteVsModify()
>> > a large block is shown to be changed compared to the old version
>> > http://egit.eclipse.org/r/#patch,sidebyside,1809,1,org.eclipse.jgit.test/tst/org/eclipse/jgit/merge/MergeAlgorithmTest.java
>>
>> We should probably file bugs against these issues when they happen,
>> otherwise we forget ;)
>
>
> Created bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=328895
> to better track the open problems reported in this thread.
Earlier tonight I posted two patches that I believe will fix these bad diff cases. I haven't yet tried to rebuild the server, but that most recent MergeAlgorithmTest case cited above appears to be fixed. I'm waiting for acks so I can build JGit from a stable revision before updating our instance.