Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [glassfish-dev] [External] : Re: Push to GlassFish site/gh-pages branch isn't working :-(

I cajoled Maxim Nesen to look at this and he identified and fixed some apparent problems in the maven plugin for deploying the site. There were also some problems with how the 5.1 legacy docs are organized and linked.

At the moment, the release version 5.1 specific links to the GlassFish "product docs." are broken -- but -- no one has touched these since they were contributed, so the "Development" versions (listed on the Docs page as "Development Version") work just fine and the site is now building again and I can now contemplate creating the CCRs for GlassFish 6.1.

I'll send a separate note about that shortly.

-- Ed

On 4/20/2021 3:03 AM, Steve Millidge (Payara) wrote:

Thanks. Looks like we need to work out how to get the additional distributions published and then rework the pom.

 

From: glassfish-dev <glassfish-dev-bounces@xxxxxxxxxxx> On Behalf Of Hussain.NM@xxxxxxxxxxxxx
Sent: 20 April 2021 11:01
To: glassfish-dev@xxxxxxxxxxx
Subject: Re: [glassfish-dev] Push to GlassFish site/gh-pages branch isn't working :-(

 

No, it will not delete the 5.1.0 folder. Only the latest folder gets deleted and symlinked in the create-latest-link goal.

 

Thanks

Hussain

 

From: glassfish-dev <glassfish-dev-bounces@xxxxxxxxxxx> On Behalf Of Steve Millidge (Payara)
Sent: Tuesday, April 20, 2021 3:27 PM
To: glassfish developer discussions <glassfish-dev@xxxxxxxxxxx>
Subject: Re: [glassfish-dev] Push to GlassFish site/gh-pages branch isn't working :-(

 

[External]

Would that make the 5.1 docs disappear from the site?

 

From: glassfish-dev <glassfish-dev-bounces@xxxxxxxxxxx> On Behalf Of Hussain.NM@xxxxxxxxxxxxx
Sent: 20 April 2021 10:55
To: glassfish-dev@xxxxxxxxxxx
Subject: Re: [glassfish-dev] Push to GlassFish site/gh-pages branch isn't working :-(

 

The intention of publish/pom.xml is documented in the README.

 

For each of the documents, there's a current version published under

the `docs/SNAPSHOT` directory, as well as stable released versions

published under the `docs/<version>` directories.

There's a `docs/latest` symlink that refers to the latest (final) release.

 

The problem we are currently facing is there has been no doc distribution released for 5.1.1 and 6.0.0. Only 5.1.0 is released and that too has a problematic pom.xml reference. As suggested by Ivar, if the get-510 goal is commented, it will generate only the docs/SNAPSHOT. The create-latest-link goal also will need to be commented to prevent it from creating a symlink to that version.

 

Thanks

Hussain

 

From: glassfish-dev <glassfish-dev-bounces@xxxxxxxxxxx> On Behalf Of Steve Millidge (Payara)
Sent: Tuesday, April 20, 2021 2:59 PM
To: glassfish developer discussions <glassfish-dev@xxxxxxxxxxx>
Subject: Re: [glassfish-dev] Push to GlassFish site/gh-pages branch isn't working :-(

 

[External]

OK that didn’t do it. I think we need help from someone that knows what the jbake stuff is doing.

 

There’s comments in the pom about adding sections when a new release is created but I also don’t really know what I’m looking at.

 

Steve

 

From: glassfish-dev <glassfish-dev-bounces@xxxxxxxxxxx> On Behalf Of Steve Millidge (Payara)
Sent: 20 April 2021 09:53
To: glassfish developer discussions <glassfish-dev@xxxxxxxxxxx>
Subject: Re: [glassfish-dev] Push to GlassFish site/gh-pages branch isn't working :-(

 

Looks like I will have to make a PR to try that.

 

I did try ticking the DEPLOY510 parameter in the job as this seems to have code to sed the poms but that is not matching on the 5.1.0-SNAPSHOT.

 

I’m trying to change the SED to also fix the 5.1.0 pom. Not sure why this has kicked in now though!

 

Steve

 

From: glassfish-dev <glassfish-dev-bounces@xxxxxxxxxxx> On Behalf Of Ivar Grimstad
Sent: 20 April 2021 08:24
To: glassfish developer discussions <glassfish-dev@xxxxxxxxxxx>
Subject: Re: [glassfish-dev] Push to GlassFish site/gh-pages branch isn't working :-(

 

Hi,

 

It looks to me that it is the step that is publishing of GlassFish 5.1.0 documentation that fails. It is configured in the execution starting on line 119 in https://github.com/eclipse-ee4j/glassfish/blob/master/docs/publish/pom.xml 

 

The reason is that the 5.1.0 Documentation pom.xml (https://search.maven.org/artifact/org.glassfish.docs/docs/5.1.0/pom) has a SNAPSHOT dependency on nucleus-parent. This snapshot does not exist anymore.

 

I suggest trying to comment out the "get-510" execution step and see if it works.

 

Ivar

 

On Tue, Apr 20, 2021 at 3:05 AM Ed Bratt <ed.bratt@xxxxxxxxxx> wrote:

Hi,

I can observe that the CI job 'glassfish-docs-publish' ran last week, after Arjan merged my changes to the 'docs' section of GlassFish/master. I can see the changes in the build workspace. But, I cannot find evidence that these updates have been pushed to the gh-pages branch (I think that is where the GitHub pages generates the site from (eclipse-ee4j.github.io/glassfish or glassfish.org).

I poked around with the logs in the Jenkins job but I don't see anything obvious though I also don't really know what to look for. I'd have thought that, someplace in that job would be a check-in/push, into the gh-pages branch of the GlassFish GIT repository. The last update to this branch appears to have been on Jan. 27th, by the glassfish-bot.

Could someone, smarter than me, please take a look and determine what we need to do to get the latest GlassFish site updates pushed to eclipse-ee4j.github.io/glassfish? It is entirely possible I'm not even looking in the right place to provide any quality commentary.

We will need to publish our TCK summary pages shortly so this has some bit of urgency.

Thanks,

-- Ed

_______________________________________________
glassfish-dev mailing list
glassfish-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/glassfish-dev


 

--

Ivar Grimstad

Jakarta EE Developer Advocate | Eclipse Foundation Eclipse Foundation - Community. Code. Collaboration. 

This e-mail and any files transmitted with it are for the sole use of the intended recipient(s) and may contain confidential and privileged information. If you are not the intended recipient(s), please reply to the sender and destroy all copies of the original message. Any unauthorized review, use, disclosure, dissemination, forwarding, printing or copying of this email, and/or any action taken in reliance on the contents of this e-mail is strictly prohibited and may be unlawful. Where permitted by applicable law, this e-mail and other e-mail communications sent to and from Cognizant e-mail addresses may be monitored.

This e-mail and any files transmitted with it are for the sole use of the intended recipient(s) and may contain confidential and privileged information. If you are not the intended recipient(s), please reply to the sender and destroy all copies of the original message. Any unauthorized review, use, disclosure, dissemination, forwarding, printing or copying of this email, and/or any action taken in reliance on the contents of this e-mail is strictly prohibited and may be unlawful. Where permitted by applicable law, this e-mail and other e-mail communications sent to and from Cognizant e-mail addresses may be monitored.


_______________________________________________
glassfish-dev mailing list
glassfish-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://urldefense.com/v3/__https://www.eclipse.org/mailman/listinfo/glassfish-dev__;!!GqivPVa7Brio!IE8Rz9gGpsC43g789Lo_aD-y_OIV9SajJkfefmAE-j_lUwgvTT54M16VbcTdraE$ 

Back to the top