Re: [wtp-dev] NewJavaClassWizardPage

[John Lanuti <jlanuti@xxxxxxxxxx>]

Naci,

I guess by the last in first out "ownership"
rules I would be considered the owner of the NewJavaClassWizardPage.
I don't think the changes you propose
fall under what Michael and David are worried about with API.  The
class is
internal at this point and your changes
will not persuade anyone to think that it is or will become API.  So,
I don't have
any issues with you making methods protected.

Thanks for the heads up,

John Lanuti
Software Engineer, IBM Rational
jlanuti@xxxxxxxxxx
t/l 441-7861

"You see this wandering soul, he's never gonna stop, because he loves
and he feels this world can grow. 
He's not afraid of feeling, he loves what he believes, he feels, and he
grows."  - Of A Revolution

Naci Dai <naci.dai@xxxxxxxxxxxxx>
Sent by: wtp-dev-bounces@xxxxxxxxxxx

05/11/2005 12:30 PM

Please respond to
naci.dai and "General discussion of project-wide or architectural issues."

To	"General discussion of project-wide or architectural issues." <wtp-dev@xxxxxxxxxxx>
cc
Subject	Re: [wtp-dev] NewJavaClassWizardPage

this was a feature enhancement request (i.e. add a
new... button, for 
the ability to create a new module from the wizard without cancelling it
to do the task).  It is more an improvement of this particular page
which requires modifications to it, not so much about making the page 
extensible and an API.  It is used by EJBs and Servlets, by allowing
some subclassing capability we can allow for some customized module 
specifi behavior, but this is all experimental.

We just did not want to change  it without approval from its owners.
Or 
you can change it as well if we want to implement that request.  
Alternative is to do a whole new page but that did not sound like a good
thing to do (replication and the  functionality can be used elsewhere).

>
> I think that extensibility from the base wizards should be driven
> through added pages, instead of extensions or additions to exising
> pages. Adding to existing pages will not scale indefinately, and we
> risk convoluting our UI from others that might share our views of
> simplicity and ease of use (all jokes about our effectiveness in 
> executing those views are welcome via bugzilla ... ;) .
>  
> That said, I think the wizards are already extensible through the
WTP 
> Wizard Framework.
>  
>  
>  
>  
> -------------------------------------------------------------------------
> Kind Regards,
>  
> Michael D. Elder
> Rational Studio / J2EE Tools Development     
> IBM RTP Lab
> Ext: (919) 543-8356
> T/L: 441-8356
> mdelder@xxxxxxxxxx
>  
>  
>  
> /Wednesday, May 11, 2005 10:30 AM
> To: naci.dai@xxxxxxxxxxxxx, "General discussion of project-wide
or 
> architectural issues." <wtp-dev@xxxxxxxxxxx>
> cc:
> From: David M Williams/Raleigh/IBM@IBMUS
> Subject: Re: [wtp-dev] NewJavaClassWizardPage/
>
>
> Since this is an internal class, I'll let the owner of that 
> class/compoent speak/decide for themselves, but I recommend at least
> 1) we don't give the impression its meant to be API (it currently
has 
> no class comments, so some should be added, as in its "experimental,
> substantial change" super class), 2) if it should be extensible
in 
> future (probably not in same way), it would be best to open a post
1.0 
> feature request to do so correctly and interested parties could track
> that bugzilla, and 3), as far as I'm concerned, fields should always
> be private, and use protected setters/getters.
>
> David
>
>
>
> *Naci Dai <naci.dai@xxxxxxxxxxxxx>*
> Sent by: wtp-dev-bounces@xxxxxxxxxxx
>
> 05/11/2005 03:00 AM
> Please respond to
> naci.dai and "General discussion of project-wide or architectural
issues."
>
>
>                  
> To
>                  "General
discussion of project-wide or architectural issues." 
> <wtp-dev@xxxxxxxxxxx>, Vijay Bhadriraju/Raleigh/IBM@IBMUS
> cc
>                  
> Subject
>                  [wtp-dev]
NewJavaClassWizardPage
>
>
>
>                  
>
>
>
>
>
> In order to address the bugzilla item
>
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=92007
>
> We need to make NewJavaClassWizardPage that helps select modules
> extensible (i.e. promote some fields and methods to be protected).
 Are
> there any issues with that?
>
>
> -- 
> Naci Dai,
> eteration a.s.
> Inonu cad. Sumer sok. Zitas D1-15
> Kozyatagi, Istanbul 34742
> +90 (533) 580 2393 (cell)
> +90 (216) 361 5434 (phone)
> +90 (216) 361 2034 (fax)
> http://www.eteration.com/
> mailto:nacidai@xxxxxxx
> mailto:naci@xxxxxxxxxxxxx
>
> _______________________________________________
> wtp-dev mailing list
> wtp-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/wtp-dev
>
>------------------------------------------------------------------------
>
>_______________________________________________
>wtp-dev mailing list
>wtp-dev@xxxxxxxxxxx
>https://dev.eclipse.org/mailman/listinfo/wtp-dev
>  
>


-- 
Naci Dai,
eteration a.s. 
Inonu cad. Sumer sok. Zitas D1-15
Kozyatagi, Istanbul 34742
+90 (533) 580 2393 (cell)
+90 (216) 361 5434 (phone)
+90 (216) 361 2034 (fax)
http://www.eteration.com/
mailto:nacidai@xxxxxxx
mailto:naci@xxxxxxxxxxxxx

_______________________________________________
wtp-dev mailing list
wtp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/wtp-dev