Sorry for the confusion that I caused.
J
> I imagine they'll look much like this:
Right.
> my assumtion was that the new impl would treat these optionally
Also right.
I re-checked. It all works well for bundles in additional.bundle that are from the _target_. In my case I have entries in additional.bundle from the target _and the
workspace_ (e.g. com.mycompany.mwe). And the workspace bundle in there cannot be resolved, since it’s not in the aggregator.
So for everyone relying on MWE, Xtext.generator or similar Tycho 2.4 will work fine, AFAICS.
And for my use case I’ll probably just add the com.mycompany.mwe also to the aggregator, even though it will never be part of the product. I can afford the some seconds of additional
build time and will use a custom checkstyle rule to make sure nobody accidentally depends on that project.
J
Mit freundlichen Grüßen / Best regards
Michael Keppler
Engineering Application Software - Chapter CI/CD and Common Infrastructure Components
T +49 711 3423-2429
Michael.Keppler@xxxxxxxx
ETAS GmbH, ETAS/ESW-CI
Borsigstraße 24, 70469 Stuttgart, Germany
www.etas.com
ETAS – Driving Embedded Excellence
Managing Directors: Christoph Hartung, Günter Gromeier, Götz Nigge
Chairman of the Supervisory Board: Dr. Walter Schirm
Registered Office: Stuttgart, Registration Court: Amtsgericht Stuttgart, HRB 19033
Von: tycho-user <tycho-user-bounces@xxxxxxxxxxx>
Im Auftrag von Ed Merks
Gesendet: Dienstag, 20. Juli 2021 16:39
An: tycho-user@xxxxxxxxxxx
Betreff: Re: [tycho-user] Please test staged tycho
I'd expect that optional dependencies generally ignored overall unless there is also a non-option dependency somewhere else. Should they be greedy?
On 20.07.2021 16:26, Christian Dietrich wrote:
my assumtion was that the new impl would treat these optionally
https://github.com/eclipse/tycho/blob/7bef880361d666a4f6cd403c39770cb4f2d36fcd/tycho-core/src/main/java/org/eclipse/tycho/core/osgitools/EquinoxResolver.java#L311
Am 20.07.21 um 16:16 schrieb Keppler Michael (ETAS/ESW-CI) via tycho-user:
We had a build failure with 2.4, but it was a problem on our side: One bundle A has an additional.bundle header containing bundle B, and B is just not part of the aggregator.
Works fine in PDE, but of course not in Tycho.
I guess the support for that header cannot be disabled via some option? I think there are quite some projects using additional.bundle for “IDE-time dependencies”, like running
MWE workflows in Xtext etc.. When used together with tycho target platform filtering, this was a nice trick to have stuff in the target only for the IDE (Junit, MWE, Xtext, …), but not for the product you build. Looks like I need to figure out a new workaround
for that.
Vorstand/Board: Jens Wagener (Vors./chairman), Dr. Stephan Eberle, Abdelghani El-Kacimi, Wolfgang Neuhaus, Franz-Josef Schuermann
Aufsichtsrat/Supervisory Board: Michael Neuhaus (Vors./chairman), Harald Goertz, Eric Swehla
Sitz der Gesellschaft/Registered Office: Am Brambusch 15-24, 44536 Lünen (Germany)
Registergericht/Registry Court: Amtsgericht Dortmund | HRB 20621
_______________________________________________
tycho-user mailing list
tycho-user@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/tycho-user
