Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [tycho-dev] Resolving Surefire Eclipse Installation wrongly uses all environments

Hopefully better this time. See


On Tue, Nov 20, 2012 at 10:18 AM, Oberlies, Tobias <tobias.oberlies@xxxxxxx> wrote:

I suppose that you want to contribute these changes, correct? This is great, but please follow the Tycho Contributor Guide






From: tycho-dev-bounces@xxxxxxxxxxx [mailto:tycho-dev-bounces@xxxxxxxxxxx] On Behalf Of Tonny Madsen
Sent: Dienstag, 20. November 2012 09:30
To: Tycho Dev List
Subject: [tycho-dev] Resolving Surefire Eclipse Installation wrongly uses all environments


Hi all,


Another pull request, I hope you can take a look at:


I have a tycho-surefire test that fails because one of the dependencies it -org.eclipse.jdt.launching.macosx - has a platform filter - (osgi.os=macosx).

As far as I can see, the test fails as the Eclipse Installation used by tycho-surefire is resolved using all the defined environments in the target-platform-configuration.environments - just like the "normal" compile environment - and not just the environment of the running platform, which I would have expected. If I temporarily removes the defined environments from the target-platform-configuration, then everything works.

Looking at the sources, I can see TestMojo (indirectly) uses P2TargetPlatformResolver.doResolvePlatform which unconditionally sets the current environment as set in target-platform-configuration before resolving the project with P2Resolved.

This patch introduces an addition to DependencyResolverConfiguration: getEnvironments(). This method is then overriden in TestMojo to just return the current executing environment.




Tonny Madsen

My profiles: Image removed by sender. LinkedIn Image removed by sender. Twitter Image removed by sender. Blogger Image removed by sender. SlideShare

tycho-dev mailing list


Tonny Madsen

My profiles: LinkedIn Twitter Blogger SlideShare

Back to the top