[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [tycho-dev] single threaded download

Quote from the commit message:
"This forces P2 to believe it always downloads artifacts remotely, even when everything is already available from maven local repository."

I don't believe that this is necessary any more. From what I understood from the p2 artifact download code, the Maven repository integration hooked into p2 in the wrong place. I believe that we have fixed this today (through a mostly correct, local Maven repository based IArtifactRepository implementation), but I never came around to refactor the download code.

Regards
Tobias


> -----Original Message-----
> From: tycho-dev-bounces@xxxxxxxxxxx [mailto:tycho-dev-bounces@xxxxxxxxxxx]
> On Behalf Of Igor Fedorenko
> Sent: Freitag, 30. September 2011 13:43
> To: tycho-dev@xxxxxxxxxxx
> Subject: Re: [tycho-dev] single threaded download
> 
> See inline
> 
> --
> Regards,
> Igor
> 
> On 11-09-30 5:19 AM, Sievers, Jan wrote:
> > any ideas why we force single threaded download in
> >
> > http://git.eclipse.org/c/tycho/org.eclipse.tycho.git/tree/tycho-
> bundles/org.eclipse.tycho.p2.resolver.impl/src/main/java/org/eclipse/tycho
> /p2/impl/resolver/ResolutionContextImpl.java#n293
> > ?
> >
> > Did we experience problems with multithreaded downloads?
> 
> Yes. Very bad performance problems for large projects like jbosstools
> when all artifacts are already cached locally.
> 
> https://github.com/sonatype/sonatype-
> tycho/commit/415fdad825e5331755945b8837ba633c7701e97b
> 
> >
> > See also the force.threading option on
> http://wiki.eclipse.org/Equinox/p2/HiddenOptions
> 
> I do not believe there is a way to set this property from Tycho. At
> least there was not way.
> 
> >
> > Jan
> > _______________________________________________
> > tycho-dev mailing list
> > tycho-dev@xxxxxxxxxxx
> > https://dev.eclipse.org/mailman/listinfo/tycho-dev
> _______________________________________________
> tycho-dev mailing list
> tycho-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/tycho-dev