|Re: [tracecompass-dev] Remaining patches for Neon|
Ok, let's try to get the debug-info patch in (https://git.eclipse.org/r/#/c/74616/) today. The other ones we keep on master.
Thanks for the clarification Bernd On 06/07/2016 09:27 AM, Alexandre Montplaisir wrote:
Hi Bernd, On 2016-06-07 07:47 AM, Bernd Hufmann wrote:Hi AlexI really would like to get these patches in but tomorrow is RC4 build. Should something goes wrong there is no chance to fix it. If we are lucky, we can as for respin of the release train. Theses patches (below) don't seem trivial fixes.What are the risks for Trace Compass (and the C/C++ EPP) if we still merge them.What would be the effect for the user if we don't merge them?They would be released in Neon.1. If needed you could create a 2.0.1 release shortly after Neon.Any thoughts? https://git.eclipse.org/r/#/c/74616/ Patch for debug-info analysisThis patch imo is very important. It allows to correctly identify a binary/library type, without it source lookup may not work at all for some libraries and the reason really won't be obvious to the user.Simon tried the feature earlier and experienced this problem, with a library he compiled by hand. I don't remember the exact details, maybe he can say more about it.Considering it's a new 2.0 feature, at worst it would not regress anything.https://git.eclipse.org/r/#/c/74092/ analysis.lami: Split axis titles in label and units https://git.eclipse.org/r/#/c/74093/ analysis.lami: Add units to timestamp axis titleThese two patches fix the display of units in LAMI charts in some conditions. It's a much smaller problem. I think the patches are very good, and will be good to have in master, but I'd be really fine with them not being in 2.0.Cheers, AlexBernd On 06/06/2016 02:48 PM, Alexandre Montplaisir wrote:I forgot two patches from Michael, which were also mentioned in Bug 493941, and would be great to have for Neon:https://git.eclipse.org/r/#/c/74092/ analysis.lami: Split axis titles in label and units https://git.eclipse.org/r/#/c/74093/ analysis.lami: Add units to timestamp axis titleThanks! Alex On 2016-06-06 12:57 PM, Alexandre Montplaisir wrote:Hi all,Here is a list of patches I'd like to get in for Neon, if someone could spare a review, it would be much appreciated:Patches in master, waiting to get in stable-2.0 https://git.eclipse.org/r/#/c/74550/ https://git.eclipse.org/r/#/c/74551/ Remaining patches about LAMI analyses https://git.eclipse.org/r/#/c/74569/ https://git.eclipse.org/r/#/c/74615/(while at it, if anyone could point out how to make the double-click/enter shortcut work, it'd be great!)Patch for debug-info analysis https://git.eclipse.org/r/#/c/74616/ (I still need to open a bug for that one)There is also a LAMI documentation patch that is coming up, we should put that up later today.Thanks! Alex_______________________________________________ tracecompass-dev mailing list tracecompass-dev@xxxxxxxxxxxTo change your delivery options, retrieve your password, or unsubscribe from this list, visit
Back to the top