Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
RE: [stp-dev] Commit: build/ - Code commit guidelines

when I said different CVS locations, I meant different CVS folders under under the STP repository, something like what oisin described in the 1st email of this thread.
 
surely that's the most efficient way to ensure that the tests will not co-mingle with the shipped code.
 
rgds,
d.

From: stp-dev-bounces@xxxxxxxxxxx [mailto:stp-dev-bounces@xxxxxxxxxxx] On Behalf Of Daniel Berg
Sent: 17 February 2006 03:55
To: STP Dev list
Cc: STP Dev list; stp-dev-bounces@xxxxxxxxxxx
Subject: Re: [stp-dev] Commit: build/ - Code commit guidelines


I disagree with this approach because the tests should be hosted in the same CVS location but you don't want to co-mingle your tests with your shipped code (directly).  Just my 2 cents.

Regards,
Dan




Alex Boisvert <boisvert@xxxxxxxxxxx>
Sent by: stp-dev-bounces@xxxxxxxxxxx

02/16/2006 09:43 AM

Please respond to
STP Dev list

To
STP Dev list <stp-dev@xxxxxxxxxxx>
cc
Subject
Re: [stp-dev] Commit: build/ - Code commit guidelines






I agree and would add that you sometime have to write your tests in the
same java package in order to test package-protected members, methods
and classes.

alex

Beaurpere, David wrote:

>I just have one comment regarding the test packaging: I wouldn't add the
>extra "tests" package layer.
>
>Frankly, I simply find it more practical to keep the tests under the
>same packaging structure as the code they are testing. Since the tests
>resources will be hosted in a distinct CVS location anyway, I do not
>really see an actual benefit for the extra package.
>
>I know this suggestion doesn't match the eclipse convention.
>
>Rgds,
>D.
>
>
>
>
>
>  
>
>>-----Original Message-----
>>From: stp-dev-bounces@xxxxxxxxxxx
>>[mailto:stp-dev-bounces@xxxxxxxxxxx] On Behalf Of Hurley, Oisin
>>Sent: 15 February 2006 17:48
>>To: STP Dev list
>>Subject: Re: [stp-dev] Commit: build/ - Code commit guidelines
>>
>>Ok, I'm making a collection of proposals for naming conventions:
>>
>>1. Differentiate between API and non-API classes by using a
>>package name element of 'internal'
>>
>>2. Differentiate between UI and non-UI classes by using a
>>package name element of 'ui'
>>
>>3. Differentiate between test and implementation classes by
>>using a package name element of 'test'
>>
>>4. Use org.eclipse.stp as the project base plugin name
>>
>>5. Use the subproject abbrevs in the plugin names e.g.
>>    org.eclipse.stp.cf.module
>>
>>So, the CVS setup would look like (as per Naci's mail):
>>
>>/releng.stpbuilder
>>  **
>>/releng
>>   /maps
>>      *.map
>>/components
>>     /soas
>>          /features
>>              /org.eclipse.stp.soas ....
>>     /sc
>>          /features
>>              /org.eclipse.stp.sc
>>          /plugins
>>              /org.eclipse.stp.sc.ui
>>              /org.eclipse.stp.sc.core
>>             ..
>>         /tests
>>              /org.eclipse.stp.sc.tests.ui
>>              /org.eclipse.stp.sc.tests.core
>>     /cf
>>       ..
>>     /b2j
>>       ..
>>     /bpmn
>>       ..
>>
>>  --oh
>>_______________________________________________
>>stp-dev mailing list
>>stp-dev@xxxxxxxxxxx
>>https://dev.eclipse.org/mailman/listinfo/stp-dev
>>
>>    
>>
>_______________________________________________
>stp-dev mailing list
>stp-dev@xxxxxxxxxxx
>https://dev.eclipse.org/mailman/listinfo/stp-dev
>  
>

_______________________________________________
stp-dev mailing list
stp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/stp-dev


Back to the top