Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [servlet-dev] Intention to release 4.0.2


On Thu, Oct 25, 2018 at 3:53 PM Greg Wilkins <gregw@xxxxxxxxxxx> wrote:

Arjans,

Commits to the release branches and specifically EE4J_8 need to be approved by a spec lead (ie Stuart or myself), so you really should not have merged #218 (even though they are good fixed and I would have approved it).

Mark,

I hear you that it would have been good to get some other changes into 4.0.2, but the intention really appears to be just minimal changes to: a) build artifacts from new repos; b) update licenses; c) new maven coords; d) new osgi coords; e) nothing else.    So let's get a 4.0.2 out on these terms and then quickly get a 4.0.3 out with the little fixes we want to get in (basically master as it is now).  

Also as an aside, just remember that this is not apache and that -1 votes are not binding.  However, having said that, I do find the whole -1, -0, +0, +1 approach a good way to express strength of feeling on a particular issue, so using it here is good... just so long as we all realise a -1 is not as binding as it may be in apache (or elsewhere). 


All,

Is the current state of EE4J_8 after the merge of #218 OK for release?

I think so, however we will have some housekeeping to do:

- We need to delete the already staged artifact, I think this needs to happen through a Jenkins job as we do not have access to the nexus UI. There was a thread about this recently on ee4j-build.
- We will need to delete the 4.0.2-RELEASE tag
- We need to do something with the 4.0.2 branch (I guess delete it, as the maven plugin will recreate it)

Stuart 

 

regards



On Thu, 25 Oct 2018 at 07:26, Mark Thomas <markt@xxxxxxxxxx> wrote:
I have confirmed which files have changed on the EE4J_8 branch since the
initial commit and submitted PR #218 to update the license headers for
those files.

I still have a bunch of changes I'd like to see in the first release but
time is running out. I'll try and submit some PRs but I suspect they
won't make it.

Mark


On 24/10/2018 11:01, arjan tijms wrote:
> Hi,
>
> I started the last staging Jenkins build on 15 October 2018, so that
> build reflects the last code changes in the EE4J_8 branch.
>
> The 4.0.2 release was staged to
> https://oss.sonatype.org/service/local/staging/deploy/maven2/jakarta/servlet/jakarta.servlet-api/4.0.2/
>
> For the full build log, see:
>
> https://jenkins.eclipse.org/servlet/job/servlet-api-release-build/lastBuild/consoleText
>
> For the last commits see:
>
> https://github.com/eclipse-ee4j/servlet-api/commits/EE4J_8
>
> Kind regards,
> Arjan Tijms
>
>
>
> On Wed, Oct 24, 2018 at 8:26 AM Mark Thomas <markt@xxxxxxxxxx
> <mailto:markt@xxxxxxxxxx>> wrote:
>
>     On October 23, 2018 11:33:17 PM UTC, Stuart Douglas
>     <sdouglas@xxxxxxxxxx <mailto:sdouglas@xxxxxxxxxx>> wrote:
>      >As I did not receive any objections to my email on the 22nd [1]
>     this is
>      >an
>      >official notification of intention to release the 4.0.2 version that
>      >has
>      >been staged (as per the release process at [2].
>      >
>      >According to the document this process involves:
>      >
>      >   - Email the dev list with an intention to release (this email)
>      >   - Create a release record
>      >   - Schedule a release review
>      >   - Notify emo@xxxxxxxxxxx <mailto:emo@xxxxxxxxxxx>
>      >   - Submit the IP log for review
>      >   - Obtain PMC approval
>      >
>      >I intend to start this process later today, and will keep the dev list
>      >updated with progress.
>      >
>      >Stuart
>      >
>      >[1] https://www.eclipse.org/lists/servlet-dev/msg00050.html
>      >[2]
>      >https://github.com/eclipse-ee4j/ee4j/wiki/How-to-release-the-first-Eclipse-version-of-projects
>
>     I'm not near my laptop but doesn't the August 'release' predate the
>     groupid fixes?
>
>     Regardless I am -1 on proceeding with either the August release or
>     the current state of EE4J_8 as some license headers have not been
>     updated when files have been changed.
>
>     Mark
>     _______________________________________________
>     servlet-dev mailing list
>     servlet-dev@xxxxxxxxxxx <mailto:servlet-dev@xxxxxxxxxxx>
>     To change your delivery options, retrieve your password, or
>     unsubscribe from this list, visit
>     https://dev.eclipse.org/mailman/listinfo/servlet-dev
>
>
>
> _______________________________________________
> servlet-dev mailing list
> servlet-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/servlet-dev
>
_______________________________________________
servlet-dev mailing list
servlet-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/servlet-dev


--
_______________________________________________
servlet-dev mailing list
servlet-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/servlet-dev

Back to the top