Re: [rdf4j-dev] delete repository bug in 4.1.0?

[Matthew Nguyen <nguyenm9@xxxxxxx>]

ah ok. Thanks Jeen.  I was looking at 3.74 impl and it seemed like some calls were pulled in the repository base class so got a little confused. 

btw- I noticed the docker image is still on 3.74.  https://hub.docker.com/r/eclipse/rdf4j-workbench

On Tuesday, August 23, 2022 at 05:34:11 PM EDT, Jeen Broekstra <jeen@xxxxxxxxxxxx> wrote:

The setup is a bit confusing but the method in RepositoryManager (which is an abstract class) is just part of the cleanup logic. The LocalRepositoryManager concrete subclass overrides the behaviour, first calling its super and then taking care of physical removal of the config and the data directory - see  https://github.com/eclipse/rdf4j/blob/d11f0ac7fb6474c96a9d6c38b626476731548c8e/core/repository/manager/src/main/java/org/eclipse/rdf4j/repository/manager/LocalRepositoryManager.java#L346. In contrast, the RemoteRepositoryManager overrides as well to just pass the removal handling on to the remote server.

Cheers,

Jeen

On Wed, 24 Aug 2022, at 09:08, Matthew Nguyen via rdf4j-dev wrote:

Hey folks, I'm looking at: https://github.com/eclipse/rdf4j/blob/main/core/repository/manager/src/main/java/org/eclipse/rdf4j/repository/manager/RepositoryManager.java#L277 and wondering when we should physically remove the repo?  looks like it just removes it from the cache with no hooks to remove it from the db.  Is it suppose to happen in the repository.shutDown() logic now or is this a bug?

matt

_______________________________________________

rdf4j-dev mailing list

rdf4j-dev@xxxxxxxxxxx

To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/rdf4j-dev

_______________________________________________
rdf4j-dev mailing list
rdf4j-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/rdf4j-dev