| Re: [platform-dev] Turn on protected branches? |
There seems to be broad agreement, so I have gone ahead and raised https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/1088 on the HelpDeskThere are a number of other branch protections we can put in place, e.g. "Require branches to be up to date before merging" and "Require linear history" which together give you something equivalent to the fast-forward-only strategy in Gerrit. But we can evolve over time.Jonah~~~_______________________________________________On Fri, 25 Mar 2022 at 06:47, Jonah Graham <jonah@xxxxxxxxxxxxxxxx> wrote:On Fri., Mar. 25, 2022, 05:32 Mickael Istria, <mistria@xxxxxxxxxx> wrote:On Fri, Mar 25, 2022 at 9:46 AM <jkubitz-eclipse@xxxxxx> wrote:Well, if direct pushing to the repository is disallowed it should be disabled. I accidently made my first error with not creating a PR. And got nor error message. Highly confusing.
Committers still and forever will have direct access to the Git repo. Having push capabilities to project repo is the very essence of being a committer over being a contributor.*Direct* push to branch is not a committer privilege, but a project choice. Protecting branches, even from committers, is a good idea. Many Gerrit projects disabled direct push (ie you had to create a gerrit review first). Github branches can (and I strongly recommend should) be protected to, at least to require a PR first.I assume these repos have force push disabled too ad I believe webmaster does that by default, but if not that should be enabled too.Jonah
platform-dev mailing list
platform-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev