[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [mosquitto-dev] Bridge doesn't honor restart_timeout setting
- From: Abilio Marques <abiliojr@xxxxxxxxx>
- Date: Tue, 6 Nov 2018 21:24:09 +0100
- Delivered-to: email@example.com
Fixed as mentioned. Created a pull request. Is my first pull request into the project, so I hope to have done everything right. A couple of tests got stuck in my computer, I would say for longer than 15 minutes each. I aborted and commented out. Please let me know if there is something I can do about them. The details for this issue is in the pull request description.
This is somewhere that has seen work in the past few releases,
fighting various issues with how it works. Setting the restart timer
to 0 on a new connection attempt certainly sounds like a good idea,
but I'd want to have a good look at it because I know there have been
changes recently. It may be that they caused a regression. If you
wanted to make some tests I'd be very happy to take them.
On Sat, 3 Nov 2018 at 10:29, Abilio Marques <abiliojr@xxxxxxxxx> wrote:
> I've been playing with the bridge connection, and for some reason, if the "remote" broker is not present, restart_timeout is only used the first time.
> I managed to fix it by doing: context->bridge->restart_t = 0
> Every time: bridge__connect(db, context);
> this code is in loop.c
> For that particular scenario, it seems to fix it, but I can't be 100% sure. I believe there are no tests for it, and the "stepped" version of connect (enabled WITH_ADNS) confuses me.
> I could submit a patch over github, but I would like to hear your opinion on this.
> mosquitto-dev mailing list
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
mosquitto-dev mailing list
To change your delivery options, retrieve your password, or unsubscribe from this list, visit