[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [mosquitto-dev] Bridge doesn't honor restart_timeout setting

Discovered a similar issue when a bridge connection, this time using ADNS. After the first connection failure, the effective wait time becomes restart_timeout + keepalive_interval.

I filled a bug report: https://github.com/eclipse/mosquitto/issues/1028 and created a pull request with the solution: https://github.com/eclipse/mosquitto/pull/1029.
The bug report includes a more detailed description of what I think is the cause of the problem.

Best,
Abilio

On Tue, Nov 6, 2018 at 9:24 PM Abilio Marques <abiliojr@xxxxxxxxx> wrote:
Fixed as mentioned. Created a pull request. Is my first pull request into the project, so I hope to have done everything right. A couple of tests got stuck in my computer, I would say for longer than 15 minutes each. I aborted and commented out. Please let me know if there is something I can do about them. The details for this issue is in the pull request description.

Thanks,
Abilio

On Tue, Nov 6, 2018 at 12:07 AM Roger Light <roger@xxxxxxxxxx> wrote:
This is somewhere that has seen work in the past few releases,
fighting various issues with how it works. Setting the restart timer
to 0 on a new connection attempt certainly sounds like a good idea,
but I'd want to have a good look at it because I know there have been
changes recently. It may be that they caused a regression. If you
wanted to make some tests I'd be very happy to take them.

Regards,

Roger

On Sat, 3 Nov 2018 at 10:29, Abilio Marques <abiliojr@xxxxxxxxx> wrote:
>
> Hello,
>
> I've been playing with the bridge connection, and for some reason, if the "remote" broker is not present, restart_timeout is only used the first time.
>
> I managed to fix it by doing: context->bridge->restart_t = 0
> Every time: bridge__connect(db, context);
>
> this code is in loop.c
>
> For that particular scenario, it seems to fix it, but I can't be 100% sure. I believe there are no tests for it, and the "stepped" version of connect (enabled WITH_ADNS) confuses me.
>
> I could submit a patch over github, but I would like to hear your opinion on this.
> Regards,
> Abilio
>
> _______________________________________________
> mosquitto-dev mailing list
> mosquitto-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://www.eclipse.org/mailman/listinfo/mosquitto-dev
_______________________________________________
mosquitto-dev mailing list
mosquitto-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/mosquitto-dev