Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [mojarra-dev] Faces 4.0: ClientWindowScoped prototyped in MyFaces
Hi,

Sorry for the late reply. I've been extremely busy with customer work and deadlines the past month. The little free time I had left I've been putting in GlassFish 6.1 for the looming March deadline. I'm therefore way, way, behind on everything concerning Faces (not just this issue). My apologies to everyone for that.

I personally like the ClientWindowScope. I can't escape the feeling that JSF 2.2 started many themes with the intention to continue with them in the JSF 2.3 timeframe, but because of reasons which are well known by now and perhaps others, this never happened. The Client ID concept is certainly such a thing, so I welcome this feature indeed.

I do like to hear what others have to say, but +1 from me for sure.

Kind regards,
Arjan Tijms




On Tue, Feb 16, 2021 at 10:50 AM Thomas Andraschko <tandraschko@xxxxxxxxxx> wrote:
it would also be ok if you agree with the API change (the new @ClientWindowScoped), everything else is impl detail.
in MyFaces we just store a Map<ClientWindowId, BeanStorage> in the ExternalContext.

Am Mo., 18. Jan. 2021 um 16:01 Uhr schrieb Thomas Andraschko <tandraschko@xxxxxxxxxx>:
any feedback here? would really like to get a bit more drive into 4.0 spec.

Am Mo., 16. Nov. 2020 um 16:04 Uhr schrieb Thomas Andraschko <tandraschko@xxxxxxxxxx>:
In general this is a simple scope based on our ClientWindow, which can be accessed via ExternalContext.
DeltaSpike has it since ages.
This implementation is a simple Map inside the session, which has a "contextual storage" for beans, for each windowId.

The only thing missing is maybe a max-limit for the clientWindowId<>Storage map.
In DeltaSpike its configurable with a default of 1024. I think we could maybe limit it to 128 or 256, or introduce a context param. But i don't think the configparam is much used in the DS community.

WDYT?

If you are ok with it, i could also try to provide a mojarra PR here.

Best regards,
Thomas


_______________________________________________
mojarra-dev mailing list
mojarra-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/mojarra-dev

Back to the top