Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [mdt-papyrus.dev] What this feature org.eclipse.papyrus.uml.diagram.example.programmaticcreation ?

hello,

 

Since the plugin is clearly non-working and that there seems to have been an agreement on suppression,

I merged the patch and removed the plugin from master (I will resolved the bug when Bugzilla is back online)

 

Regards,

Benoit

 

De : mdt-papyrus.dev-bounces@xxxxxxxxxxx [mailto:mdt-papyrus.dev-bounces@xxxxxxxxxxx] De la part de LE FEVRE FRANCOIS
Envoyé : mardi 26 septembre 2017 11:05
À : Papyrus Project list <mdt-papyrus.dev@xxxxxxxxxxx>
Objet : [PROVENANCE INTERNET] Re: [mdt-papyrus.dev] [PROVENANCE INTERNET] What this feature org.eclipse.papyrus.uml.diagram.example.programmaticcreation ?

 

Hey Benoit,

 

Patrick has already taken a decision on it: “delete it”.

I have made a contribution in August on the topic [6] to reflect this decision.

 

Could you confirm Patrick?

 

Thanks

 

 

[6] : https://git.eclipse.org/r/#/c/103777/

 

 

De : mdt-papyrus.dev-bounces@xxxxxxxxxxx [mailto:mdt-papyrus.dev-bounces@xxxxxxxxxxx] De la part de MAGGI Benoit
Envoyé : lundi 25 septembre 2017 17:01
À : Papyrus Project list <mdt-papyrus.dev@xxxxxxxxxxx>
Objet : [PROVENANCE INTERNET] [mdt-papyrus.dev] What this feature org.eclipse.papyrus.uml.diagram.example.programmaticcreation ?

 

Hello,

 

When looking in Papyrus keybinding, I discovered 2 commands registered  by “dummy” name in Papyrus [1]

The commands are provided by org.eclipse.papyrus.uml.diagram.example.programmaticcreation [2]

 

I pushed a patch to change that [3] and also fixing some quality warnings.

While refactoring, it occurs to me that the commands will always fail with NPE L 67 [4] and L58 [5]

 

Can we just remove this buggy plugin?

 

Regards,

Benoit

 

1 : https://bugs.eclipse.org/bugs/show_bug.cgi?id=522746

2: https://git.eclipse.org/c/papyrus/org.eclipse.papyrus.git/tree/examples/uml/org.eclipse.papyrus.uml.diagram.example.programmaticcreation/plugin.xml

3: https://git.eclipse.org/r/#/c/105723/

4: https://git.eclipse.org/c/papyrus/org.eclipse.papyrus.git/tree/examples/uml/org.eclipse.papyrus.uml.diagram.example.programmaticcreation/src/org/eclipse/papyrus/uml/diagram/example/programmaticcreation/CreateSequenceDiagramElementsCommand.java

5: https://git.eclipse.org/c/papyrus/org.eclipse.papyrus.git/tree/examples/uml/org.eclipse.papyrus.uml.diagram.example.programmaticcreation/src/org/eclipse/papyrus/uml/diagram/example/programmaticcreation/CreateCompositeDiagramElementsCommand.java

 

 

 

 

 


Back to the top