Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [mdt-bpmn2.dev] Changing resolve proxies to false for FlowNode incoming and outgoing

The formatting settings, including line width, are already specified as project settings and should take effect. So everyone should automatically use the same formatting settings (and there are in fact a lot less changes due to formatting, just a few of the kind mentioned in my previous mail).

As everyone uses the same settings, the only point of variation I can think of is the version of the formatter algorithm. The algorithm was changed sometime during the Helios release cycle (now preferring to wrap in front of method calls, like the example below).

If different versions are not the cause, I think we have to live with the small disturbances.

Regards,
Henning

2010/7/28 Antoine Toulme <antoine@xxxxxxxxxxxxxxx>

Thanks Henning. I think Eclipse picks up the line width from somewhere ?

We could commit project settings to make sure to use the same formatting for all users of the project.

Sorry I didn't notice the incoming flaw.

On Wed, Jul 28, 2010 at 09:17, Henning Heitkötter <hheitkoetter@xxxxxxxxxxxxxx> wrote:
Hi Antoine,

I regenerated the code for FlowNode, because it only reflected the changed property for the reference "outgoing", not for incoming (resolveProxies was set to false in the Ecore file, but this was not reflected in the code).

When regenerating, I noticed that we still have some noise wrt formatting despite having the default formatting profile. An example of formatting changes that occur when I regenerate (I didn't submit these with my commit):

-            adHocSubProcessEClass = (EClass) EPackage.Registry.INSTANCE.getEPackage(
-                    Bpmn2Package.eNS_URI).getEClassifiers().get(3);
+            adHocSubProcessEClass = (EClass) EPackage.Registry.INSTANCE
+                    .getEPackage(Bpmn2Package.eNS_URI).getEClassifiers().get(3);

Of course that's just a small annoyance, but an annoyance nonetheless :-). Could it relate to different versions of the formatter/Eclipse? FWIW, I'm using the Helios release.

Regards,
Henning

2010/7/24 Antoine Toulme <antoine@xxxxxxxxxxxxxxx>
Flow nodes seem to be setting the wrong ids for incoming and outgoing references. It currently uses a IDREF like so : virtual.bpmn2#my_id.

Instead it should be using the ID string only. I changed resolving proxies to false for those two references. I'll commit my changes now.

Thanks,

Antoine

_______________________________________________
mdt-bpmn2.dev mailing list
mdt-bpmn2.dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/mdt-bpmn2.dev






Back to the top