Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jta-dev] Any objections to not requiring a review from a committer for any PR raised by a committer merging their PR?
Ok, something breaks the sailboat image in the PDF (for me at least, tested on 2 machines). Updating the PNG (https://github.com/jgallimore/jta-api/commit/69a3148abf6fe9e3f564678987c6b2cfb12b4377) seems to fix it.

I'm ok if you want to merge, and I'll send a PR for the image.

Thanks Tom!

Jon

On Fri, Sep 18, 2020 at 10:52 AM Tom Jenkinson <tom.jenkinson@xxxxxxxxxx> wrote:
Thanks Jonathan!

On Fri, 18 Sep 2020 at 10:30, Jonathan Gallimore <jgallimore@xxxxxxxxxxxxx> wrote:
Just looking at your PR now - I see its been open for 9 days, so sorry I didn't review sooner. I have a couple of things to check - specifically the parent pom, and I'd like to run the build and read the document produced. I'll have this done in the next hour.

Jon

On Fri, Sep 18, 2020 at 10:24 AM Jonathan Gallimore <jgallimore@xxxxxxxxxxxxx> wrote:
Sounds like we need to do better at reviewing your PRs. I'll go through everything that's there for review now.

I personally don't object to not requiring a review - its still possible to review changes after they have been committed, and things can be reverted or fixed as necessary. For complex changes, I'd expect the author to want a review, and chase it up if that is taking a long time. 

If we do see complex changes going in with no review repeatedly, we can discuss that here.

Jon

On Fri, Sep 18, 2020 at 10:16 AM Tom Jenkinson <tom.jenkinson@xxxxxxxxxx> wrote:
Hi,

Would anyone object to not requiring a review from a committer for any PR raised by a committer merging their PR?

I guess we should choose an amount of days to wait for feedback? Maybe 7 days from when the PR was opened?

I am not sure if there is a procedure to go through to formalise this so I will leave this thread open for any feedback until at least Tuesday 10am UTC+0.

Thanks,
Tom
_______________________________________________
jta-dev mailing list
jta-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jta-dev


--
Jonathan Gallimore


--
Jonathan Gallimore
_______________________________________________
jta-dev mailing list
jta-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jta-dev
_______________________________________________
jta-dev mailing list
jta-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jta-dev


--
Jonathan Gallimore

Back to the top