Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jta-dev] Any objections to not requiring a review from a committer for any PR raised by a committer merging their PR?
Sounds like we need to do better at reviewing your PRs. I'll go through everything that's there for review now.

I personally don't object to not requiring a review - its still possible to review changes after they have been committed, and things can be reverted or fixed as necessary. For complex changes, I'd expect the author to want a review, and chase it up if that is taking a long time. 

If we do see complex changes going in with no review repeatedly, we can discuss that here.

Jon

On Fri, Sep 18, 2020 at 10:16 AM Tom Jenkinson <tom.jenkinson@xxxxxxxxxx> wrote:
Hi,

Would anyone object to not requiring a review from a committer for any PR raised by a committer merging their PR?

I guess we should choose an amount of days to wait for feedback? Maybe 7 days from when the PR was opened?

I am not sure if there is a procedure to go through to formalise this so I will leave this thread open for any feedback until at least Tuesday 10am UTC+0.

Thanks,
Tom
_______________________________________________
jta-dev mailing list
jta-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jta-dev


--
Jonathan Gallimore

Back to the top