[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jgit-dev] autocrlf=input with CRLF in repository does not behave like C Git

Is this still an issue? Is there anything I can help with?

Cheers,
Tomasz

On Wed, Dec 18, 2013 at 11:29 AM, Matthias Sohn <matthias.sohn@xxxxxxxxx> wrote:
> On Tue, Dec 17, 2013 at 5:53 PM, Matthias Sohn <matthias.sohn@xxxxxxxxx>
> wrote:
>>
>> On Sun, Dec 15, 2013 at 10:05 PM, Matthias Sohn <matthias.sohn@xxxxxxxxx>
>> wrote:
>>>
>>> On Sun, Dec 15, 2013 at 3:16 PM, Robin Rosenberg
>>> <robin.rosenberg@xxxxxxxxxx> wrote:
>>>>
>>>>
>>>> Sorry, for top-posting...
>>>>
>>>> I've been using a CRLF'ed working tree on a Mac. Wish some Windows users
>>>> could
>>>> test this too before release, or even before merge.
>>>
>>>
>>> I'll try to find time to test this on windows tomorrow
>>
>>
>> took me a while to get my Windows laptop working again, tried your patch
>> and it greatly improves the handling of autocrlf, no more false dirty
>> states.
>> The only difference I found compared to native git is handling of files
>> with
>> mixed line endings, native git doesn't normalize them but jgit does.
>> Is this related to missing support of safecrlf ?
>>
>> There is still some room for performance improvements but I think we
>> should include this change now for 3.2 and then work on these improvements
>> as currently autocrlf is pretty unusable.
>
>
> it looks like this patch is causing a regression, the egit ui test
> CreatePatchActionTest is failing
> with this patch, it succeeds without this patch :-(
>
> --
> Matthias
>
> _______________________________________________
> jgit-dev mailing list
> jgit-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/jgit-dev
>