Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jgit-dev] [egit-dev] Any chance for some feeback on those 2 patches?

Hi Tomasz

thanks for the quick feeback!
I'll take actions and get back.


On 01/25/2013 10:49 AM, Tomasz Zarna wrote:
Hi Andre,

No one will do a review as long as Hudson is not happy with the
change. If you're 100% sure the failures are not related to your
patch, and the tests pass locally add a comment about it.

@JGit: Haven't looked at the code yet, but does it make sense to add a
test case for the new API you added?

@EGit: There is a special tag for marking EGit changes dependent on
JGit i.e. "JGit-Dependency", please add it to the commit message.


On Fri, Jan 25, 2013 at 10:05 AM, André Dietisheim <adietish@xxxxxxxxxx> wrote:

In order to be able to display server message while we're pushing (like
screencasted here:,
I did 2 patches for egit and jgit and pushed those to gerrit: -> ->

Juno SR2is pretty much close ahead, so I'd appreciate a lot if we could get
some feedback on those?


egit-dev mailing list

Back to the top