[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jgit-dev] guru question about RevWalk - RevCommit buffer suddenly null

On 06/01/2012 04:29 PM, Shawn Pearce wrote:
> On Fri, Jun 1, 2012 at 4:45 AM, Markus Duft <markus.duft@xxxxxxxxxx> wrote:
[snip]
> This is basically correct. We discard the body of an UNINTERESTING
> commit to reduce memory load. The PARSED flag means we have the
> structure of the commit loaded in order to have it participate in
> traversals. It does not imply that the body buffer and the additional
> metadata like author name are available. For that you need to make
> sure parseBody is called.
> 
> The walker promises that results returned that are interesting should
> have bodies. There may be a bug here that we don't do this when a
> commit switches from UNINTERESTING. Thus far I have said that its up
> to the application that is running a RevWalk more than once that may
> have this state change happen worry about doing the parseBody call
> itself, rather than having RevWalk always do the check internally
> before returning a result, because it makes the common case of running
> a RevWalk once faster.  :-)

heh, if thats the official statement, i'm ok with it ;) it was the fix that i applied anyway, but now i'm sure i'm not doing something dumb. thanks :)