[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [jgit-dev] core.streamFileThreshold and large objects
- From: Markus Duft <markus.duft@xxxxxxxxxx>
- Date: Fri, 01 Jun 2012 11:42:13 +0200
- Delivered-to: firstname.lastname@example.org
- Organization: Salomon Automation GmbH
- User-agent: Mozilla/5.0 (X11; Linux i686; rv:12.0) Gecko/20120502 Thunderbird/12.0.1
On 06/01/2012 11:12 AM, Marc Strapetz wrote:
> When reading a LargePackedDeltaObject it usually (or always?) results in
> a hang, hence I'd prefer to not use this code at all. To achieve that I
> could increase the streamFileTheshold to Integer.MAX_VALUE. On the other
> hand, it makes sense to stream a LargePackedWholeObject. So what about
> introducing a system property in PackFile which avoids instantiation of
> a LargePackedDeltaObject, basically:
i debugged the code a while ago , and i realized, that it does not hang at all. it's just so dead slow, that it will never finish ;) i tried this with a 200MB file, and it managed to process ~100MB in 12 hours IIRC...
maybe this should just be fixed instead of changing limits.
> if (sz < curs.getStreamFileThreshold() || (delta != null && SYS_PROP))
> data = decompress(pos + p, (int) sz, curs);
> and some fixes to not catch OOME at #decompress?
> Personally, I'd always have that property enabled as even an OOME is
> better than a hang.
> Best regards,
> Marc Strapetz
> syntevo GmbH
> jgit-dev mailing list