[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jgit-dev] [egit-dev] preparing 2.0

(Restored mailing lists=
John Arthorne skrev 2012-05-31 23.30:
The current state is that JGitInternalException is no longer declared on the API, but it is still thrown. For example if there is a transport failure such as validation
failure, it now throws an unchecked internal exception. How are clients supposed to handle this?

We are trying to figure out how to react to this change downstream in Orion:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=381148

I don't think authentication exceptions should be classified as JGitInternalException. We have a TransportException in the API, but apparently it is not used properly.

I pushed https://git.eclipse.org/r/#/c/6207/ for review. See if it makes sense for you. With
that you should be able to catch authentication error using TransportException.

This also fixed a some cases where GitAPIException was caught and translated, which I
do not think is entirely correct.

-- robin

John Arthorne

On Sat, May 26, 2012 at 3:57 AM, Robin Rosenberg

    I pushed a change to remove JGitInternalException from the API.

    We also have the issue of most every exception below the GitAPI being an IOException.
    Some probably still should be, but not all of them.

    -- robin





    _________________________________________________
    egit-dev mailing list
    egit-dev@xxxxxxxxxxx <mailto:egit-dev@xxxxxxxxxxx>
    https://dev.eclipse.org/__mailman/listinfo/egit-dev <https://dev.eclipse.org/mailman/listinfo/egit-dev>