Re: [jakartaee-tck-dev] compatibility alert: Do (Platform TCK) tests tha

[Scott Marlow <smarlow@xxxxxxxxxx>]

On Fri, Apr 29, 2022, 3:53 PM Scott Marlow <smarlow@xxxxxxxxxx> wrote:

On 4/29/22 10:45 AM, arjan tijms wrote:

Hi,

On Fri, Apr 29, 2022 at 3:58 PM Scott Marlow <smarlow@xxxxxxxxxx> wrote:

I would like confirmation that the Faces 4.0 SPEC team agrees that all (Faces 4.0) application deployment requires CDI to be enabled which is a breaking change and probably should be added to the Faces 4.0 SPEC document.

Essentially Faces has required CDI to be available since JSF 2.3. Various features (such as custom data models) required CDI in that version.

So it's true that Faces 4.0 requires CDI, but it's somewhat debatable given its history whether that's 100% a new change in 4.0. Nevertheless we can add it explicitly in the spec that it's a strict requirement.

Thanks Arjan!

https://github.com/eclipse-ee4j/jakartaee-tck/pull/952 is a draft pull request for adding the beans.xml that seems to avoid the "java.lang.IllegalStateException: CDI is not available" from being thrown from the `ejblitejsf` tests that include the faces-config.xml.  The `ejblitejsf` tests seem to still fail (will have to figure out why). 

I started a longer test run to see what the impact is of the change via https://ci.eclipse.org/jakartaee-tck/job/jakartaee-tck-scottmarlow/job/faces_beansxml/3

The results of this test shows the deployment problem is not happening anymore with the https://github.com/eclipse-ee4j/jakartaee-tck/pull/952 change.  I converted the pr from draft to not draft pr.  It is now ready for review and then merging.  From my manual inspection, I could see that the beans.xml is copied to the war.  Nice that it was handled via a single ant script change.

Scott

Scott

Kind regards,

Arjan Tijms

 

_______________________________________________
jakartaee-tck-dev mailing list
jakartaee-tck-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev