Re: [jakartaee-platform-dev] Question about JSP spec api signature testi

[carlos andres de la rosa <kusanagi12002@xxxxxxxxx>]

Checking the method implementation looks that is not using the generic part to make any validation, for me can be removed but is necessary runs after the tcks to be sure that other things are not broken, that is my 2 cents

Thanks

Cheers 

On Thu, Aug 29, 2019 at 8:07 PM Scott Marlow <smarlow@xxxxxxxxxx> wrote:

Please see [1] which has some JSP signature test failures that I saw
with JSP API signature testing.

Should we remove the generics from the method signatures?  For example
for [2], should we change from:

public static final Tag findAncestorWithClass(Tag from, Class<?> klass)

To:

public static final Tag findAncestorWithClass(Tag from, Class klass) {

Thanks,
Scott

[1]
https://github.com/eclipse-ee4j/jsp-api/issues/118#issuecomment-526297341

[2]
https://github.com/eclipse-ee4j/jsp-api/blob/2.3.6/api/src/main/java/javax/servlet/jsp/tagext/TagSupport.java#L66
_______________________________________________
jakartaee-platform-dev mailing list
jakartaee-platform-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jakartaee-platform-dev

--

Carlos Andres De La Rosa | Software Architect

Mobile: +32465445631  

Skype: carlosa.dlr