Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jakartaee-examples-dev] Simple Initial Commit - Signed-off-by

My understanding is, ECA validator checks that the e-mail you used for sign-off, matches with the e-mail from your Eclipse user account.

The ECA validator at accounts.eclipse.org seems to accept jpollard91@xxxxxxx as valid. Ken the validator accepts omniprof@xxxxxxxxx as well. The contributor terms were updated in 2018. Perhaps you need to update your ECA? If you can log in and check your ECA status, that might help sort this out.

Only project committers can merge PRs. Once you have a PR that passes the ECA validator, a project committer can merge in your changes into the repository.

If someone has a recipe for retroactively fixing a missing sign-off key, that would certainly be something worthy of a bookmark.

I am confident, once you are past this initial stumble, you'll be able to work with more efficiency.

Thank you for your support!

-- Ed

On 4/29/2020 7:12 PM, Jason Pollard wrote:
Sounds good, one day at a time and we will get there. ��

Get Outlook for iOS
From: jakartaee-examples-dev-bounces@xxxxxxxxxxx <jakartaee-examples-dev-bounces@xxxxxxxxxxx> on behalf of omniprof@xxxxxxxxx <omniprof@xxxxxxxxx>
Sent: Wednesday, April 29, 2020 9:10:07 PM
To: 'jakartaee-examples developer discussions' <jakartaee-examples-dev@xxxxxxxxxxx>
Subject: Re: [jakartaee-examples-dev] Simple Initial Commit - Signed-off-by
 

I’ll try the nuclear option in the morning. The ECA validator looks like the way to go. I think I have to clear up the ‘did not sign the right document to contribute issue’ first.

 

 

From: jakartaee-examples-dev-bounces@xxxxxxxxxxx <jakartaee-examples-dev-bounces@xxxxxxxxxxx> On Behalf Of Jason Pollard
Sent: April 29, 2020 9:56 PM
To: jakartaee-examples developer discussions <jakartaee-examples-dev@xxxxxxxxxxx>
Subject: Re: [jakartaee-examples-dev] Simple Initial Commit - Signed-off-by

 

Hey Ken,

 

I probably would create a new one. Since this was my first commit, I actually chose the nuclear option and re-forked with a fresh commit. 

 

I'll probably start validating with the Eclipse Validator in my own fork in the future (i.e., create a branch in my fork, PR my own branch to my own master, validate, and then to PR from my master to upstream master). Eclipse Validatotion GitHub app: https://github.com/apps/eclipse-eca-validation

Image removed by sender.

Provides an Eclipse contributor and committer validation service for authors of a GitHub pull request.. validation of pull request contributors against our Eclipse Foundation Contributor Validation service.

github.com

 

 

There is a git command that can "rewrite history" with signoffs, but I'm not entirely comfortable with it: https://stackoverflow.com/questions/38310726/sign-off-on-a-range-of-previous-commits-in-git-even-after-a-push

Image removed by sender.

How do you sign off on a range of previous commits starting from HEAD in git even after performing a push while retaining all other information?

stackoverflow.com

It does look like my PR has no issues now, so it can be merged once it is reviewed.

 

As far as updating Arquillian target app servers, it looks like the Arquillian Chameleon GitHub project hasn't been updated recently for app servers (and there are open issues for this too). So I might look at making some updates to that project as well, for the sake of JakartaEE samples. 😂

 

Thanks all,

Jason Pollard

 

From: jakartaee-examples-dev-bounces@xxxxxxxxxxx <jakartaee-examples-dev-bounces@xxxxxxxxxxx> on behalf of omniprof@xxxxxxxxx <omniprof@xxxxxxxxx>
Sent: Wednesday, April 29, 2020 9:41 PM
To: 'jakartaee-examples developer discussions' <jakartaee-examples-dev@xxxxxxxxxxx>
Subject: Re: [jakartaee-examples-dev] Simple Initial Commit - Signed-off-by

 

Hi,

 

I just did a third commit with the required signed-off-by. Should I just cancel the pull request and then make the request again?

 

Ken

 

From: Ed Bratt <ed.bratt@xxxxxxxxxx>
Sent: April 29, 2020 9:36 PM
To: jakartaee-examples developer discussions <jakartaee-examples-dev@xxxxxxxxxxx>; Jason Pollard <jpollard91@xxxxxxx>; omniprof@xxxxxxxxx
Subject: Re: [jakartaee-examples-dev] Simple Initial Commit - Signed-off-by

 

Sorry, should have addressed this to Jason. Ken's PR has the identical problem, though his PR is 16.

On 4/29/2020 6:32 PM, Ed Bratt wrote:

Ken,

 

Re: PR 17

In my experience, the ECA validator is fairly picky. I am not a GIT expert but I believe the validator checks each commit. Your first commit did not include the signed-off-by tag. The second did, but from the validator's perspective, that first one is still unverifiable.

In my experience, the easiest thing to do is to cancel (delete) the PR and submit it again, this time with the signed-off-by flag.

There maybe a way to retroactively fix that commit, but I can't provide you with a reliable recipe for doing that.

-- Ed

On 4/29/2020 6:13 PM, Jason Pollard wrote:

Hi all,

 

I have also done my first PR for the samples project (my 2nd OSS PR 🙂). It is a simple addition of some .gitignore lines for those of us using IntelliJ.

 

I am getting a persistent error about the Signed-off-by footer. I did add a commit with "git -s -m 'commit message'". I did check that I used the same email address as what I used to sign the ECA. Any thoughts?

 

A few more questions as we move forward with making this repo super awesome:

 

  • Should we use Bugzilla as a primary tracker, or is it OK to use the issues in GitHub? Can I add a few issues (for tracking), once we decide?
  • I'd like to update the Arquillian profiles next. Any thoughts on whether we should we reference the list (of open source) application servers and versions from here? https://jakarta.ee/compatibility/ Or latest versions of same? Does anyone know if TomEE is certified yet?

I appreciate all the feedback from the committers and others who are teaching us about how to work with the project, and Ken for diving into the deep end!

 

Cheers,

Jason Pollard

 

 

_______________________________________________
jakartaee-examples-dev mailing list
jakartaee-examples-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-examples-dev

 

_______________________________________________
jakartaee-examples-dev mailing list
jakartaee-examples-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-examples-dev

_______________________________________________
jakartaee-examples-dev mailing list
jakartaee-examples-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-examples-dev

Back to the top