Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jakartaee-examples-dev] Simple Initial Commit - Signed-off-by

Sorry, should have addressed this to Jason. Ken's PR has the identical problem, though his PR is 16.

On 4/29/2020 6:32 PM, Ed Bratt wrote:

Ken,


Re: PR 17

In my experience, the ECA validator is fairly picky. I am not a GIT expert but I believe the validator checks each commit. Your first commit did not include the signed-off-by tag. The second did, but from the validator's perspective, that first one is still unverifiable.

In my experience, the easiest thing to do is to cancel (delete) the PR and submit it again, this time with the signed-off-by flag.

There maybe a way to retroactively fix that commit, but I can't provide you with a reliable recipe for doing that.

-- Ed

On 4/29/2020 6:13 PM, Jason Pollard wrote:
Hi all,

I have also done my first PR for the samples project (my 2nd OSS PR 🙂). It is a simple addition of some .gitignore lines for those of us using IntelliJ.

I am getting a persistent error about the Signed-off-by footer. I did add a commit with "git -s -m 'commit message'". I did check that I used the same email address as what I used to sign the ECA. Any thoughts?

A few more questions as we move forward with making this repo super awesome:

  • Should we use Bugzilla as a primary tracker, or is it OK to use the issues in GitHub? Can I add a few issues (for tracking), once we decide?
  • I'd like to update the Arquillian profiles next. Any thoughts on whether we should we reference the list (of open source) application servers and versions from here? https://jakarta.ee/compatibility/ Or latest versions of same? Does anyone know if TomEE is certified yet?
I appreciate all the feedback from the committers and others who are teaching us about how to work with the project, and Ken for diving into the deep end!

Cheers,
Jason Pollard


_______________________________________________
jakartaee-examples-dev mailing list
jakartaee-examples-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-examples-dev


_______________________________________________
jakartaee-examples-dev mailing list
jakartaee-examples-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-examples-dev

Back to the top